Skip to content

Update docs for RN SDK v5#6230

Merged
krystofwoldrich merged 11 commits intomasterfrom
react-native-v5
Feb 21, 2023
Merged

Update docs for RN SDK v5#6230
krystofwoldrich merged 11 commits intomasterfrom
react-native-v5

Conversation

@krystofwoldrich
Copy link
Copy Markdown
Contributor

@krystofwoldrich krystofwoldrich commented Feb 6, 2023

@krystofwoldrich krystofwoldrich requested a review from a team as a code owner February 6, 2023 15:03
@vercel
Copy link
Copy Markdown

vercel bot commented Feb 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 0:39AM (UTC)

@marandaneto
Copy link
Copy Markdown
Contributor

marandaneto commented Feb 6, 2023

Instead of replacing everything, what's about using v4 and v5 tabs for a while? I'm wondering if this would avoid further issues while adoption grows slowly.

@krystofwoldrich
Copy link
Copy Markdown
Contributor Author

krystofwoldrich commented Feb 7, 2023 •
edited
Loading

I would maybe refactor the troubleshooting React Native 0.69 and Higher to SDK v4 with React Native 0.69 and Higher and to the installation guide, I would add a note.

The commands are the same but I've changed the notes from how to fix for new RN versions to how to fix for older versions.

Also, a lot of the changes are because I change a bit of the structure, moving the Expo part, and updating what the wizard does that applies to v4 too as far as I know.

Update: I've added a note and instructions for the v4. I think is clearer this way. The default will be the latest as it works with the latest 3 versions of RN and the note has instructions for SDK v4.

marandaneto
marandaneto reviewed Feb 7, 2023
View reviewed changes
@marandaneto
Copy link
Copy Markdown
Contributor

marandaneto commented Feb 7, 2023

The Wizard docs are missing (project creation setup on sentry.io)
https://github.com/getsentry/sentry-docs/tree/master/src/wizard/react-native

lizokm
lizokm approved these changes Feb 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some language tweaks

@krystofwoldrich @lizokm
Apply suggestions from code review
680c283 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@krystofwoldrich krystofwoldrich requested review from a team and lizokm February 14, 2023 10:06
@krystofwoldrich
Copy link
Copy Markdown
Contributor Author

krystofwoldrich commented Feb 14, 2023

The migration guide and wizard page have been updated and not reviewed yet.

kahest
kahest reviewed Feb 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrt migration and wizard docs: few small nits, otherwise LGTM! 👍

@krystofwoldrich @kahest
Apply suggestions from code review
5b97b5a 
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
@krystofwoldrich krystofwoldrich changed the title Update setup for RN SDK v5 Update docs for RN SDK v5 Feb 21, 2023
@krystofwoldrich krystofwoldrich merged commit 2a721a1 into master Feb 21, 2023
@krystofwoldrich krystofwoldrich deleted the react-native-v5 branch February 21, 2023 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lizokm lizokm Awaiting requested review from lizokm

2 more reviewers

@kahest kahest kahest approved these changes

@marandaneto marandaneto marandaneto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krystofwoldrich @marandaneto @kahest @lizokm