Add React Router Info to Onboarding Wizard #7136
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ale-cota
requested review from
a team,
Lms24,
priscilawebdev and
smeubank
and removed request for
a team
src/wizard/javascript/react/with-error-monitoring-and-performance.md
Outdated
Show resolved
Hide resolved
priscilawebdev
left a comment
priscilawebdev
left a comment
There was a problem hiding this comment.
left a suggestion but it looks good to me
src/wizard/javascript/react/with-error-monitoring-and-performance.md
Outdated
Show resolved
Hide resolved
src/wizard/javascript/react/with-error-monitoring-performance-and-replay.md
Outdated
Show resolved
Hide resolved
|
How much work would it be to add a toggle which says with or without react router? can be off by default stretch: link to doc "How to detect if your app uses react-router" |
@smeubank What should this control? Would it slap the setup instructions on the page directly? I see they're also version dependent, so I think it requires a better design approach. I'd leave just the link in "Next Steps" for now because it's already an improvement to the existing and will create a separate ticket to investigate how we could introduce the instructions too. |
2nd: the argument would be to just add it to the snippet with a comment that says your can remove or check other version in docs the extra mile |
Add React Router Info to: *src/wizard/javascript/react/index.md * src/wizard/javascript/react/with-error-monitoring-performance-and-replay.md * src/wizard/javascript/react/with-error-monitoring-and-performance.md
Since setting up React Router is key for getting parameterised transaction names, adding this suggestion to the next steps when the Performance product is selected.