fix(rn): Update CodePush commands to generate and upload source maps#7791
Merged
krystofwoldrich merged 1 commit intomasterfrom Sep 26, 2023
Merged
fix(rn): Update CodePush commands to generate and upload source maps#7791krystofwoldrich merged 1 commit intomasterfrom
krystofwoldrich merged 1 commit intomasterfrom
Conversation
…with latest appcenter cli
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
11 tasks
HazAT
approved these changes
Sep 13, 2023
shanamatthews
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to Error stack trace not deobfuscated when using codepush bundle (Hermes + codepush) sentry-react-native#3279
related appcenter cli pr fix(help): Release React command update
output-dirhelp desc microsoft/appcenter-cli#2452reflects the current behavior of the appcenter cli https://github.com/microsoft/appcenter-cli/blob/7b637743eec2fd4e960823bfa76fe568c4f5e4ff/src/commands/codepush/release-react.ts#L89-L100
combination of
--sourcemap-outputand--output-dirno longer works.source map path must be explicitly set
Bundle will be generated in ./path/CodePush -> source maps should not be in the same directory. So sentry-cli commands have to include paths to source map dir and bundle dir.