Skip to content

Conversation

@maciejwalkowiak
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

  • remove captureException from Sentry class
  • add overloaded version of captureTransaction on Hub.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

Changes are breaking for current master but not for the latest released version.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1065 (38db633) into main (c5e02c9) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1065   +/-   ##
=========================================
  Coverage     72.95%   72.95%           
  Complexity     1520     1520           
=========================================
  Files           161      161           
  Lines          5461     5461           
  Branches        550      550           
=========================================
  Hits           3984     3984           
  Misses         1187     1187           
  Partials        290      290           
Impacted Files Coverage Δ Complexity Δ
sentry/src/main/java/io/sentry/HubAdapter.java 9.25% <0.00%> (ø) 4.00 <0.00> (ø)
sentry/src/main/java/io/sentry/IHub.java 80.00% <0.00%> (-5.72%) 8.00 <0.00> (ø)
sentry/src/main/java/io/sentry/Sentry.java 43.07% <ø> (+0.32%) 18.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e02c9...38db633. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit c327574 into main Nov 24, 2020
@maciejwalkowiak maciejwalkowiak deleted the performance-drop-capture-exception branch November 24, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants