Feat/poc continuous profiling #4556

lbloder · 2025-07-15T20:00:54Z

📜 Description

💡 Motivation and Context

Initial implementation of #2635

💚 How did you test it?

📝 Checklist

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Investigate why TRACE lifecycle profiles do not show up in Sentry (Support ProfileLifecycle.TRACE #4576)
Add external option for profile lifecycle (Support ProfileLifecycle.TRACE #4576)

Note

Adds async-profiler–backed JVM continuous profiling with ServiceLoader SPI, new SentryProfile payload in ProfileChunk, TRACE lifecycle start/stop, and related options/rate-limiting updates.

Profiling (JVM):
- Introduces sentry-async-profiler module (async-profiler 3.0) with providers for JavaContinuousProfiler and JFR→Sentry conversion.
- New ServiceLoader SPIs: JavaContinuousProfilerProvider, JavaProfileConverterProvider and loader ProfilingServiceLoader.
Profile payload/serialization:
- Extend ProfileChunk with platform, profile (structured SentryProfile) and precise timestamps; keep Base64 path for Android; add PLATFORM_ANDROID/PLATFORM_JAVA.
- New protocol types: profiling.SentryProfile, SentrySample, SentryThreadMetadata; SentryStackFrame equality/hash.
SDK integration:
- Auto-init JVM profiler and fallback traces dir; start/stop on root spans for TRACE in Scopes and OTel span processor; propagate profiler id to spans/transactions.
- Envelope item builds profile via converter for JVM, Base64 for Android.
Options & external config:
- Add profile-session-sample-rate, profiling-traces-dir-path, profile-lifecycle; expose in SentryOptions and properties parsing.
Rate limiting:
- Support profile_chunk category in addition to profile_chunk_ui.
Android:
- Mark Android profile chunks with PLATFORM_ANDROID.
Build/Samples/CI:
- Register new module in settings; ignore vendored async-profiler in Codecov; sample apps wired with profiler deps and env props; minor DSN host tweak.
Tests:
- Extensive unit tests for profiling SPI, serialization, service loading, options, rate limiting, and async-profiler module.

^{Written by Cursor Bugbot for commit 66413a0. This will update automatically on new commits. Configure here.}

…sed on jfr converter bundled with asyncprofiler

… use existing SentryStackFrame instead of JfrFrame,

…inuous profiler in sentry init

…t in SentrySpan to work around scientific notation of double, use wall clock profiling

# Conflicts: # sentry/build.gradle.kts # sentry/src/test/java/io/sentry/ExternalOptionsTest.kt # sentry/src/test/java/io/sentry/JsonSerializerTest.kt # sentry/src/test/java/io/sentry/SentryClientTest.kt # sentry/src/test/java/io/sentry/SentryOptionsTest.kt

…using external options

…d of file extension

…ofilerTest

github-actions · 2025-07-15T20:01:26Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 66413a0

github-actions · 2025-07-15T20:17:42Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	388.26 ms	488.10 ms	99.84 ms
Size	1.58 MiB	2.10 MiB	535.09 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`b750b96`	408.98 ms	480.32 ms	71.34 ms
`ee747ae`	357.79 ms	421.84 ms	64.05 ms
`3998a95`	415.94 ms	478.54 ms	62.60 ms
`85d7417`	347.21 ms	394.35 ms	47.15 ms
`806307f`	357.85 ms	424.64 ms	66.79 ms
`d217708`	409.83 ms	474.72 ms	64.89 ms
`c8125f3`	397.65 ms	485.14 ms	87.49 ms
`ee747ae`	396.82 ms	441.67 ms	44.86 ms
`3699cd5`	423.60 ms	495.52 ms	71.92 ms
`f634d01`	359.58 ms	433.88 ms	74.30 ms

App size

Revision	Plain	With Sentry	Diff
`b750b96`	1.58 MiB	2.10 MiB	533.19 KiB
`ee747ae`	1.58 MiB	2.10 MiB	530.95 KiB
`3998a95`	1.58 MiB	2.10 MiB	532.96 KiB
`85d7417`	1.58 MiB	2.10 MiB	533.44 KiB
`806307f`	1.58 MiB	2.10 MiB	533.42 KiB
`d217708`	1.58 MiB	2.10 MiB	532.97 KiB
`c8125f3`	1.58 MiB	2.10 MiB	532.32 KiB
`ee747ae`	1.58 MiB	2.10 MiB	530.95 KiB
`3699cd5`	1.58 MiB	2.10 MiB	533.45 KiB
`f634d01`	1.58 MiB	2.10 MiB	533.40 KiB

Previous results on branch: feat/poc-continuous-profiling

Startup times

Revision	Plain	With Sentry	Diff
`0939549`	368.64 ms	439.17 ms	70.52 ms
`212c151`	372.36 ms	456.94 ms	84.58 ms
`abfc274`	384.37 ms	412.52 ms	28.15 ms
`f172894`	363.82 ms	424.87 ms	61.06 ms
`9e8e7bb`	381.60 ms	425.33 ms	43.72 ms

App size

Revision	Plain	With Sentry	Diff
`0939549`	1.58 MiB	2.10 MiB	535.24 KiB
`212c151`	1.58 MiB	2.10 MiB	533.69 KiB
`abfc274`	1.58 MiB	2.10 MiB	535.19 KiB
`f172894`	1.58 MiB	2.10 MiB	535.19 KiB
`9e8e7bb`	1.58 MiB	2.10 MiB	533.10 KiB

sentry/src/main/java/io/sentry/protocol/profiling/JfrToSentryProfileConverter.java

sentry/src/main/java/io/sentry/protocol/profiling/SentrySample.java

sentry/src/main/java/io/sentry/protocol/profiling/JfrFrame.java

.../src/main/java/io/sentry/asyncprofiler/provider/AsyncProfilerContinuousProfilerProvider.java

.../src/main/java/io/sentry/asyncprofiler/convert/JfrAsyncProfilerToSentryProfileConverter.java

adinauer · 2025-07-22T10:07:30Z

@sentry review

.../src/main/java/io/sentry/asyncprofiler/convert/JfrAsyncProfilerToSentryProfileConverter.java

sentry/src/main/java/io/sentry/SentryEnvelopeItem.java

sentry/src/main/java/io/sentry/SentryTracer.java

…sentry-java into feat/poc-continuous-profiling

github-actions · 2025-09-30T11:05:22Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

github-actions · 2025-09-30T11:05:48Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

github-actions · 2025-09-30T11:08:15Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

sentry/src/main/java/io/sentry/SentryEnvelopeItem.java

sentry/src/main/java/io/sentry/Sentry.java

sentry/src/main/java/io/sentry/SentryTracer.java

adinauer · 2025-09-30T12:00:46Z

@cursor review

adinauer · 2025-09-30T12:00:59Z

@sentry review

sentry/src/main/java/io/sentry/SentryTracer.java

sentry/src/main/java/io/sentry/protocol/profiling/SentrySample.java

sentry/src/main/java/io/sentry/Sentry.java

...y-async-profiler/src/main/java/io/sentry/asyncprofiler/profiling/JavaContinuousProfiler.java

sentry/src/main/java/io/sentry/Sentry.java

sentry/src/main/java/io/sentry/SentryEnvelopeItem.java

…sentry-java into feat/poc-continuous-profiling

github-actions · 2025-09-30T13:05:49Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

github-actions · 2025-09-30T13:19:24Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

github-actions · 2025-09-30T13:20:26Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

github-actions · 2025-09-30T13:41:20Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

cursor · 2025-09-30T13:47:04Z

...sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/OtelSentrySpanProcessor.java

+        && scopes.getOptions().isContinuousProfilingEnabled()
+        && scopes.getOptions().getProfileLifecycle() == ProfileLifecycle.TRACE) {
+      scopes.getOptions().getContinuousProfiler().stopProfiler(ProfileLifecycle.TRACE);
+    }


Bug: Profiler Stops Prematurely for Unsampled Spans

The OtelSentrySpanProcessor.onEnd method stops the continuous profiler for root spans without checking if the span was sampled or if its profiler ID matches the currently active global profiler. This can lead to the profiler stopping prematurely, affecting other active traces.

lbloder added 21 commits April 25, 2025 12:14

wip

f32782c

Merge branch 'main' into feat/poc-continuous-profiling

4fd36d2

re-add data category profile_chunk, fix json naming, new converter ba…

0e2a1b7

…sed on jfr converter bundled with asyncprofiler

read java thread ids from jfr and use those instead of os thread ids,…

558ff79

… use existing SentryStackFrame instead of JfrFrame,

adhere to sentry conventions re format null safety etc, fix compilation

04c82de

add profile-session-sample-rate to external options

f44e7fd

add platform as constructor param to ProfileChunk, wip: set java cont…

8b4c71a

…inuous profiler in sentry init

add doubleToBigDecimal in JfrSample and ProfileChunk, same as we do i…

a44287b

…t in SentrySpan to work around scientific notation of double, use wall clock profiling

rename JfrProfile to SentryProfile

9cf7ef6

move java profiling into its own module, load using SPI

5534204

[WIP] use getProfilingTracesDirPath

cabc384

add missing build.gradle.kts for profiler module

ec59901

Merge branch 'main' into feat/poc-continuous-profiling

54c3a8f

WIP continuous profiling in trace mode

543fc40

cleanup unused classes from vendor, cleanup packages

fba1881

allow setting profiling-traces-dir-path independently from cache dir …

55df61c

…using external options

use profileChunk.platform to decide how to deal with the chunk instea…

9bcd4ea

…d of file extension

port relevant AndroidContinuousProfilerTest tests to JavaContinuousPr…

3f83146

…ofilerTest

add service loader tests for profiler and profile converter

4a7403a

remove old jfr test files

03a20dd

lbloder commented Jul 22, 2025

View reviewed changes

sentry/src/main/java/io/sentry/protocol/profiling/JfrToSentryProfileConverter.java Outdated Show resolved Hide resolved

lbloder commented Jul 22, 2025

View reviewed changes

sentry/src/main/java/io/sentry/protocol/profiling/SentrySample.java Show resolved Hide resolved

lbloder commented Jul 22, 2025

View reviewed changes

sentry/src/main/java/io/sentry/protocol/profiling/JfrFrame.java Outdated Show resolved Hide resolved

lbloder commented Jul 22, 2025

View reviewed changes

.../src/main/java/io/sentry/asyncprofiler/provider/AsyncProfilerContinuousProfilerProvider.java Outdated Show resolved Hide resolved

lbloder commented Jul 22, 2025

View reviewed changes

.../src/main/java/io/sentry/asyncprofiler/convert/JfrAsyncProfilerToSentryProfileConverter.java Outdated Show resolved Hide resolved

seer-by-sentry bot reviewed Jul 22, 2025

View reviewed changes

.../src/main/java/io/sentry/asyncprofiler/convert/JfrAsyncProfilerToSentryProfileConverter.java Outdated Show resolved Hide resolved

Format code

1321c03

cursor bot reviewed Sep 29, 2025

View reviewed changes

sentry/src/main/java/io/sentry/SentryEnvelopeItem.java Show resolved Hide resolved

sentry/src/main/java/io/sentry/SentryTracer.java Show resolved Hide resolved

lbloder added 2 commits September 30, 2025 13:04

mark SentryThreadMetadata internal

2298748

Merge branch 'feat/poc-continuous-profiling' of github.com:getsentry/…

8e027d8

…sentry-java into feat/poc-continuous-profiling

Merge branch 'main' into feat/poc-continuous-profiling

7d29d34

add changelog entry

9a11e02

Format code

e5ffefb

cursor bot reviewed Sep 30, 2025

View reviewed changes

sentry/src/main/java/io/sentry/SentryEnvelopeItem.java Show resolved Hide resolved

sentry/src/main/java/io/sentry/Sentry.java Show resolved Hide resolved

sentry/src/main/java/io/sentry/SentryTracer.java Show resolved Hide resolved

cursor bot reviewed Sep 30, 2025

View reviewed changes

sentry/src/main/java/io/sentry/SentryTracer.java Show resolved Hide resolved

sentry/src/main/java/io/sentry/protocol/profiling/SentrySample.java Outdated Show resolved Hide resolved

sentry/src/main/java/io/sentry/Sentry.java Show resolved Hide resolved

seer-by-sentry bot reviewed Sep 30, 2025

View reviewed changes

lbloder added 3 commits September 30, 2025 15:05

re-add asyncprofiler classes, cr changes

b065ef1

bump api

13dbc8e

Merge branch 'feat/poc-continuous-profiling' of github.com:getsentry/…

40c6756

…sentry-java into feat/poc-continuous-profiling

detect dangerous/invalid chars in profiling directory name

91e244d

Merge branch 'main' into feat/poc-continuous-profiling

81ad659

ignore vendored profile conversion code in codecov

66413a0

cursor bot reviewed Sep 30, 2025

View reviewed changes

adinauer merged commit 0e2c478 into main Oct 1, 2025
70 of 72 checks passed

adinauer deleted the feat/poc-continuous-profiling branch October 1, 2025 07:11

lbloder mentioned this pull request Oct 3, 2025

Add sentry-async-profiler module getsentry/sentry-release-registry#211

Merged

bruno-garcia mentioned this pull request Oct 3, 2025

Continuous Profiling getsentry/sentry-dotnet#4592

Open

Uh oh!

Feat/poc continuous profiling #4556

Feat/poc continuous profiling #4556

Uh oh!

Conversation

lbloder commented Jul 15, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/poc-continuous-profiling

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adinauer commented Jul 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2025 • edited by lbloder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 30, 2025 • edited by lbloder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 30, 2025 • edited by lbloder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adinauer commented Sep 30, 2025

Uh oh!

adinauer commented Sep 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2025 • edited by lbloder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 30, 2025 • edited by lbloder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 30, 2025 • edited by lbloder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 30, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

cursor bot Sep 30, 2025

lbloder commented Jul 15, 2025 •

edited by cursor bot

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading

github-actions bot commented Sep 30, 2025 •

edited by lbloder

Loading

github-actions bot commented Sep 30, 2025 •

edited by lbloder

Loading

github-actions bot commented Sep 30, 2025 •

edited by lbloder

Loading

github-actions bot commented Sep 30, 2025 •

edited by lbloder

Loading

github-actions bot commented Sep 30, 2025 •

edited by lbloder

Loading

github-actions bot commented Sep 30, 2025 •

edited by lbloder

Loading