feat!: Remove support for Node < v18 and webpack v4

.github/dependency-review-config.yml

@@ -0,0 +1,4 @@
+fail-on-severity: "critical"
+allow-ghsas:
+  # If we support webpack v5.0.0, we need to use those types and test that version
+  - GHSA-hc6q-2mpp-qw7j

.github/workflows/checks.yml

@@ -131,17 +131,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [
-            # nx uses a `yargs-parser` versision which isn't compatible with node 10
-            # "10.24.1",
-            # vite uses optional chaining which isn't compatible with node 12
-            # "12.22.12",
-            "14",
-            "16",
-            "18",
-            "20",
-            "22",
-          ]
+        node-version: ["18", "20", "22"]
         os: [ubuntu-latest, windows-latest]
     runs-on: ${{ matrix.os }}
     steps:

README.md

@@ -6,7 +6,7 @@
 
 # Sentry Bundler Plugins
 
-Sentry plugins for various JavaScript bundlers. Currently supporting Rollup, Vite, esbuild, Webpack 4 and Webpack 5.
+Sentry plugins for various JavaScript bundlers. Currently supporting Rollup, Vite, esbuild, Webpack 5.
 
 Check out the individual packages for more information and examples:
 

packages/e2e-tests/package.json

@@ -28,7 +28,6 @@
     "@types/axios": "^0.14.0",
     "@types/glob": "8.0.0",
     "@types/jest": "^28.1.3",
-    "@types/webpack4": "npm:@types/webpack@^4",
     "esbuild": "0.14.49",
     "eslint": "^8.18.0",
     "glob": "8.0.3",
@@ -37,8 +36,7 @@
     "rollup": "3.2.0",
     "ts-node": "^10.9.1",
     "vite": "3.0.0",
-    "webpack4": "npm:webpack@^4",
-    "webpack5": "npm:webpack@5.74.0"
+    "webpack": "5.74.0"
   },
   "volta": {
     "extends": "../../package.json"

packages/e2e-tests/utils/bundlers.ts

@@ -1 +1 @@
-export const BUNDLERS = ["rollup", "vite", "esbuild", "webpack4", "webpack5"];
+export const BUNDLERS = ["rollup", "vite", "esbuild", "webpack"];

packages/e2e-tests/utils/create-cjs-bundles.ts

@@ -1,8 +1,7 @@
 import * as vite from "vite";
 import * as path from "path";
 import * as rollup from "rollup";
-import { default as webpack4 } from "webpack4";
-import { webpack as webpack5 } from "webpack5";
+import { webpack } from "webpack";
 import * as esbuild from "esbuild";
 
 import type { Options } from "@sentry/bundler-plugin-core";
@@ -91,43 +90,13 @@ export function createCjsBundles(
     format: "cjs",
   });
 
-  webpack4(
-    {
-      devtool: "source-map",
-      mode: "production",
-      entry: entrypoints,
-      cache: false,
-      output: {
-        path: path.join(outFolder, "webpack4"),
-        libraryTarget: "commonjs",
-      },
-      target: "node", // needed for webpack 4 so we can access node api
-      plugins: [
-        sentryWebpackPlugin({
-          ...sentryPluginOptions,
-          release: {
-            name: `${sentryPluginOptions.release.name!}-webpack4`,
-            uploadLegacySourcemaps: `${
-              sentryPluginOptions.release.uploadLegacySourcemaps as string
-            }/webpack4`,
-          },
-        }),
-      ],
-    },
-    (err) => {
-      if (err) {
-        throw err;
-      }
-    }
-  );
-
-  webpack5(
+  webpack(
     {
       devtool: "source-map",
       cache: false,
       entry: entrypoints,
       output: {
-        path: path.join(outFolder, "webpack5"),
+        path: path.join(outFolder, "webpack"),
         library: {
           type: "commonjs",
         },
@@ -137,10 +106,10 @@ export function createCjsBundles(
         sentryWebpackPlugin({
           ...sentryPluginOptions,
           release: {
-            name: `${sentryPluginOptions.release.name!}-webpack5`,
+            name: `${sentryPluginOptions.release.name!}-webpack`,
             uploadLegacySourcemaps: `${
               sentryPluginOptions.release.uploadLegacySourcemaps as string
-            }/webpack5`,
+            }/webpack`,
           },
         }),
       ],

packages/integration-tests/fixtures/after-upload-deletion-promise/after-upload-deletion.test.ts

@@ -2,15 +2,10 @@
 /* eslint-disable jest/expect-expect */
 import path from "path";
 import fs from "fs";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 describe("Deletes files with `filesToDeleteAfterUpload` set to a promise", () => {
-  testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
-    expect(fs.existsSync(path.join(__dirname, "out", "webpack4", "bundle.js.map"))).toBe(false);
-  });
-
   test("webpack 5 bundle", () => {
-    expect(fs.existsSync(path.join(__dirname, "out", "webpack5", "bundle.js.map"))).toBe(false);
+    expect(fs.existsSync(path.join(__dirname, "out", "webpack", "bundle.js.map"))).toBe(false);
   });
 
   test("esbuild bundle", () => {

packages/integration-tests/fixtures/after-upload-deletion-promise/setup.ts

@@ -3,7 +3,7 @@ import { createCjsBundles } from "../../utils/create-cjs-bundles";
 
 const outputDir = path.resolve(__dirname, "out");
 
-["webpack4", "webpack5", "esbuild", "rollup", "vite"].forEach((bundler) => {
+["webpack", "esbuild", "rollup", "vite"].forEach((bundler) => {
   const fileDeletionGlobPromise = new Promise<string[]>((resolve) => {
     setTimeout(() => {
       resolve([path.join(__dirname, "out", bundler, "bundle.js.map")]);

packages/integration-tests/fixtures/after-upload-deletion/after-upload-deletion.test.ts

@@ -2,15 +2,10 @@
 /* eslint-disable jest/expect-expect */
 import path from "path";
 import fs from "fs";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 describe("Deletes with `filesToDeleteAfterUpload` even without uploading anything", () => {
-  testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
-    expect(fs.existsSync(path.join(__dirname, "out", "webpack4", "bundle.js.map"))).toBe(false);
-  });
-
-  test("webpack 5 bundle", () => {
-    expect(fs.existsSync(path.join(__dirname, "out", "webpack5", "bundle.js.map"))).toBe(false);
+  test("webpack bundle", () => {
+    expect(fs.existsSync(path.join(__dirname, "out", "webpack", "bundle.js.map"))).toBe(false);
   });
 
   test("esbuild bundle", () => {

packages/integration-tests/fixtures/after-upload-deletion/setup.ts

@@ -3,7 +3,7 @@ import { createCjsBundles } from "../../utils/create-cjs-bundles";
 
 const outputDir = path.resolve(__dirname, "out");
 
-["webpack4", "webpack5", "esbuild", "rollup", "vite"].forEach((bundler) => {
+["webpack", "esbuild", "rollup", "vite"].forEach((bundler) => {
   createCjsBundles(
     {
       bundle: path.resolve(__dirname, "input", "bundle.js"),

packages/integration-tests/fixtures/application-key-injection/metadata-injection.test.ts

@@ -2,7 +2,6 @@
 /* eslint-disable jest/expect-expect */
 import { execSync } from "child_process";
 import path from "path";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 function checkBundle(bundlePath: string): void {
   const output = execSync(`node ${bundlePath}`, { encoding: "utf-8" });
@@ -16,12 +15,8 @@ function checkBundle(bundlePath: string): void {
 }
 
 describe("appKey injection", () => {
-  testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
-    checkBundle(path.join(__dirname, "out", "webpack4", "bundle.js"));
-  });
-
   test("webpack 5 bundle", () => {
-    checkBundle(path.join(__dirname, "out", "webpack5", "bundle.js"));
+    checkBundle(path.join(__dirname, "out", "webpack", "bundle.js"));
   });
 
   test("esbuild bundle", () => {

packages/integration-tests/fixtures/application-key-injection/setup.ts

@@ -11,5 +11,5 @@ createCjsBundles(
   {
     applicationKey: "my-app",
   },
-  ["webpack4", "webpack5", "esbuild", "rollup", "vite"]
+  ["webpack", "esbuild", "rollup", "vite"]
 );

packages/integration-tests/fixtures/application-key-with-debug-id/application-key-with-debug-id.test.ts

@@ -2,7 +2,6 @@
 /* eslint-disable jest/expect-expect */
 import { execSync } from "child_process";
 import path from "path";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 interface BundleOutput {
   debugIds: Record<string, string> | undefined;
@@ -35,12 +34,8 @@ function checkBundle(bundlePath: string): void {
 }
 
 describe("applicationKey with debug ID injection", () => {
-  testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
-    checkBundle(path.join(__dirname, "out", "webpack4", "bundle.js"));
-  });
-
   test("webpack 5 bundle", () => {
-    checkBundle(path.join(__dirname, "out", "webpack5", "bundle.js"));
+    checkBundle(path.join(__dirname, "out", "webpack", "bundle.js"));
   });
 
   test("esbuild bundle", () => {

packages/integration-tests/fixtures/application-key-with-debug-id/setup.ts

@@ -14,5 +14,5 @@ createCjsBundles(
     telemetry: false,
     release: { name: "test-release", create: false },
   },
-  ["webpack4", "webpack5", "esbuild", "rollup", "vite"]
+  ["webpack", "esbuild", "rollup", "vite"]
 );

packages/integration-tests/fixtures/basic-release-injection/basic-release-injection.test.ts

@@ -1,6 +1,5 @@
 import childProcess from "child_process";
 import path from "path";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 /**
  * Runs a node file in a seprate process.
@@ -28,12 +27,7 @@ test("vite bundle", () => {
   checkBundle(path.join(__dirname, "./out/vite/index.js"));
 });
 
-testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
-  expect.assertions(1);
-  checkBundle(path.join(__dirname, "./out/webpack4/index.js"));
-});
-
 test("webpack 5 bundle", () => {
   expect.assertions(1);
-  checkBundle(path.join(__dirname, "./out/webpack5/index.js"));
+  checkBundle(path.join(__dirname, "./out/webpack/index.js"));
 });

packages/integration-tests/fixtures/build-information-injection/build-information-injection.test.ts

@@ -1,6 +1,5 @@
 import childProcess from "child_process";
 import path from "path";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 /**
  * Runs a node file in a seprate process.
@@ -15,14 +14,8 @@ function checkBundle(bundlePath: string): void {
 
   expect(JSON.parse(processOutput)).toEqual(
     expect.objectContaining({
-      deps: expect.arrayContaining<string>([
-        "esbuild",
-        "rollup",
-        "vite",
-        "webpack4",
-        "webpack5",
-      ]) as string[],
-      depsVersions: { rollup: 3, vite: 3, react: 18 },
+      deps: expect.arrayContaining<string>(["esbuild", "rollup", "vite", "webpack"]) as string[],
+      depsVersions: { rollup: 3, vite: 3, react: 18, webpack: 5 },
       // This will differ based on what env this is run on
       nodeVersion: expectedNodeVersion,
     })
@@ -44,12 +37,7 @@ test("vite bundle", () => {
   checkBundle(path.join(__dirname, "out", "vite", "index.js"));
 });
 
-testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
+test("webpack bundle", () => {
   expect.assertions(1);
-  checkBundle(path.join(__dirname, "out", "webpack4", "index.js"));
-});
-
-test("webpack 5 bundle", () => {
-  expect.assertions(1);
-  checkBundle(path.join(__dirname, "out", "webpack5", "index.js"));
+  checkBundle(path.join(__dirname, "out", "webpack", "index.js"));
 });

packages/integration-tests/fixtures/bundle-size-optimizations/bundle-size-optimizations.test.ts

@@ -2,7 +2,6 @@
 /* eslint-disable jest/expect-expect */
 import path from "path";
 import fs from "fs";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 const expectedOutputs: Record<string, Record<string, string>> = {
   esbuild: {
@@ -24,11 +23,7 @@ const expectedOutputs: Record<string, Record<string, string>> = {
     "bundle1.js": `console.log(1);`,
     "bundle2.js": `console.log({debug:"b",trace:"b",replayCanvas:"a",replayIframe:"a",replayShadowDom:"a",replayWorker:"a"})`,
   },
-  webpack4: {
-    "bundle1.js": `console.log(1)`,
-    "bundle2.js": `console.log({debug:"b",trace:"b",replayCanvas:"a",replayIframe:"a",replayShadowDom:"a",replayWorker:"a"})`,
-  },
-  webpack5: {
+  webpack: {
     "bundle1.js": `console.log(1)`,
     "bundle2.js": `console.log({debug:"b",trace:"b",replayCanvas:"a",replayIframe:"a",replayShadowDom:"a",replayWorker:"a"})`,
   },
@@ -59,12 +54,7 @@ test("vite bundle", () => {
   checkBundle("vite", "bundle2.js");
 });
 
-testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
-  checkBundle("webpack4", "bundle1.js");
-  checkBundle("webpack4", "bundle2.js");
-});
-
 test("webpack 5 bundle", () => {
-  checkBundle("webpack5", "bundle1.js");
-  checkBundle("webpack5", "bundle2.js");
+  checkBundle("webpack", "bundle1.js");
+  checkBundle("webpack", "bundle2.js");
 });

packages/integration-tests/fixtures/component-name-annotate-experimental/component-name-annotate-experimental.test.ts

@@ -1,6 +1,5 @@
 import childProcess from "child_process";
 import path from "path";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 const SNAPSHOT = `"<div><span data-sentry-component=\\"ComponentA\\">Component A</span></div>"`;
 const ESBUILD_SNAPSHOT = `"<div><span>Component A</span></div>"`;
@@ -25,12 +24,7 @@ test("vite bundle", () => {
   checkBundle(path.join(__dirname, "./out/vite/index.js"));
 });
 
-testIfNodeMajorVersionIsLessThan18("webpack 4 bundle if node is < 18", () => {
-  expect.assertions(1);
-  checkBundle(path.join(__dirname, "./out/webpack4/index.js"));
-});
-
 test("webpack 5 bundle", () => {
   expect.assertions(1);
-  checkBundle(path.join(__dirname, "./out/webpack5/index.js"));
+  checkBundle(path.join(__dirname, "./out/webpack/index.js"));
 });

packages/integration-tests/fixtures/component-name-annotate/component-name-annotate.test.ts

@@ -1,6 +1,5 @@
 import childProcess from "child_process";
 import path from "path";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 const SNAPSHOT = `"<div><span data-sentry-component=\\"ComponentA\\" data-sentry-source-file=\\"component-a.jsx\\">Component A</span></div>"`;
 const ESBUILD_SNAPSHOT = `"<div><span>Component A</span></div>"`;
@@ -25,12 +24,7 @@ test("vite bundle", () => {
   checkBundle(path.join(__dirname, "./out/vite/index.js"));
 });
 
-testIfNodeMajorVersionIsLessThan18("webpack 4 bundle if node is < 18", () => {
-  expect.assertions(1);
-  checkBundle(path.join(__dirname, "./out/webpack4/index.js"));
-});
-
 test("webpack 5 bundle", () => {
   expect.assertions(1);
-  checkBundle(path.join(__dirname, "./out/webpack5/index.js"));
+  checkBundle(path.join(__dirname, "./out/webpack/index.js"));
 });

packages/integration-tests/fixtures/debug-id-injection/debug-id-injection.test.ts

@@ -2,7 +2,6 @@
 /* eslint-disable jest/expect-expect */
 import childProcess from "child_process";
 import path from "path";
-import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf";
 
 function checkBundle(bundlePath1: string, bundlePath2: string): string[] {
   const process1Output = childProcess.execSync(`node ${bundlePath1}`, { encoding: "utf-8" });
@@ -51,16 +50,9 @@ test("vite bundle", () => {
   );
 });
 
-testIfNodeMajorVersionIsLessThan18("webpack 4 bundle", () => {
-  checkBundle(
-    path.join(__dirname, "out", "webpack4", "bundle1.js"),
-    path.join(__dirname, "out", "webpack4", "bundle2.js")
-  );
-});
-
 test("webpack 5 bundle", () => {
   checkBundle(
-    path.join(__dirname, "out", "webpack5", "bundle1.js"),
-    path.join(__dirname, "out", "webpack5", "bundle2.js")
+    path.join(__dirname, "out", "webpack", "bundle1.js"),
+    path.join(__dirname, "out", "webpack", "bundle2.js")
   );
 });