-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Description
Description
Currently, we SDK behaviour differs (slightly) if we in higher level SDKs or users in general pass undefined to certain SDK init options instead of not setting them at all.
Examples:
defaultIntegrations: undefinedcauses no default integrations to be installed while not settingdefaultIntegrationsmeans default integrations get installed - fixed in fix(browser): Initialize default integration ifdefaultIntegrations: undefined#13261tracesSampleRate: undefinedmakes thehasTracingEnabledreturntrue, while not setting it (assuming no other tracing options are set) makeshasTracingEnabledreturnfalse.
Ideally, we just call dropUndefinedKeys on the user-passed options and move on. However, for this to work we need to change the implementation of hasTracingEnabled to not differentiate between the two possibilities. Also this questions the validity of hasTracingEnabled entirely because even if no sample rates are set at all, "Tracing without Performance" should be enabled.