feat(remix): Add Vite dev-mode support to Express instrumentation. #10784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/remix-vite-dev-mode-async
branch
2 times, most recently
from
5fa1f6d to
959990a
Compare
Contributor
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/remix-vite-dev-mode-async
branch
3 times, most recently
from
ee4af65 to
7d2cc21
Compare
onurtemizkan
commented
Feb 23, 2024
Comment on lines
+15
to
+26
| "@remix-run/css-bundle": "2.7.2", | ||
| "@remix-run/node": "2.7.2", | ||
| "@remix-run/react": "2.7.2", | ||
| "@remix-run/serve": "2.7.2", | ||
| "isbot": "^3.6.8", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@playwright/test": "^1.36.2", | ||
| "@remix-run/dev": "2.0.0", | ||
| "@remix-run/eslint-config": "2.0.0", | ||
| "@remix-run/dev": "2.7.2", | ||
| "@remix-run/eslint-config": "2.7.2", |
Collaborator
Author
There was a problem hiding this comment.
Also updated this to latest, to make sure the ErrorBoundary works with the latest Remix in production mode.
onurtemizkan
commented
Feb 23, 2024
|
|
||
| expect(hadPageNavigationTransaction).toBe(true); | ||
| }); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I had to remove ErrorBoundary test here, as it's not the same eventId we log, when it's reported to Sentry in dev mode.
I can confirm that the same event with a different id is reported to Sentry, but there are multiple events on dev-server mode which get deduped. We can try to address this in a follow-up PR.
Can also confirm that that test as-is passes on production mode.
onurtemizkan
force-pushed
the
onur/remix-vite-dev-mode-async
branch
from
7d2cc21 to
7b9dafa
Compare
AbhiPrasad
reviewed
Feb 23, 2024
Member
There was a problem hiding this comment.
@onurtemizkan could you please expand the PR description to add details about what changes you made?
Woops spoke too soon, thanks for updating!
AbhiPrasad
approved these changes
Feb 26, 2024
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Let's get this backported onto v7 as well!
onurtemizkan
added a commit
that referenced
this pull request
Feb 26, 2024
…10784) Resolves #10724 Related: #9500 Adds dev-mode support to Remix setups with Vite and Express. We currently accept Remix server `build` as an object to instrument. But Remix allows `build` as a synchronous or asynchronous function that returns the build object. Currently, it seems that functions are only used in development servers, and not in production. So, while this update slightly reduces `requestHandler` performance on dev servers, it does not on production builds. We need `build` in 2 places: 1- We instrument the loaders / actions on build, then we pass them down to the original implementations. 2- We use the `routes` inside them to create parameterised transactions. This update adds new internal wrappers around them to make sure that we don't miss out on the returned / resolved values in case `build` is a function, for both cases. This PR also adds a new E2E test application using the latest Remix version and Vite, and it runs the tests on `dev` mode. We also need a documentation update to reflect this, if it gets merged.
onurtemizkan
added a commit
that referenced
this pull request
Feb 26, 2024
…10784) Resolves #10724 Related: #9500 Adds dev-mode support to Remix setups with Vite and Express. We currently accept Remix server `build` as an object to instrument. But Remix allows `build` as a synchronous or asynchronous function that returns the build object. Currently, it seems that functions are only used in development servers, and not in production. So, while this update slightly reduces `requestHandler` performance on dev servers, it does not on production builds. We need `build` in 2 places: 1- We instrument the loaders / actions on build, then we pass them down to the original implementations. 2- We use the `routes` inside them to create parameterised transactions. This update adds new internal wrappers around them to make sure that we don't miss out on the returned / resolved values in case `build` is a function, for both cases. This PR also adds a new E2E test application using the latest Remix version and Vite, and it runs the tests on `dev` mode. We also need a documentation update to reflect this, if it gets merged.
onurtemizkan
added a commit
that referenced
this pull request
Feb 28, 2024
…10784) Resolves #10724 Related: #9500 Adds dev-mode support to Remix setups with Vite and Express. We currently accept Remix server `build` as an object to instrument. But Remix allows `build` as a synchronous or asynchronous function that returns the build object. Currently, it seems that functions are only used in development servers, and not in production. So, while this update slightly reduces `requestHandler` performance on dev servers, it does not on production builds. We need `build` in 2 places: 1- We instrument the loaders / actions on build, then we pass them down to the original implementations. 2- We use the `routes` inside them to create parameterised transactions. This update adds new internal wrappers around them to make sure that we don't miss out on the returned / resolved values in case `build` is a function, for both cases. This PR also adds a new E2E test application using the latest Remix version and Vite, and it runs the tests on `dev` mode. We also need a documentation update to reflect this, if it gets merged.
onurtemizkan
added a commit
that referenced
this pull request
Mar 7, 2024
…10784) Resolves #10724 Related: #9500 Adds dev-mode support to Remix setups with Vite and Express. We currently accept Remix server `build` as an object to instrument. But Remix allows `build` as a synchronous or asynchronous function that returns the build object. Currently, it seems that functions are only used in development servers, and not in production. So, while this update slightly reduces `requestHandler` performance on dev servers, it does not on production builds. We need `build` in 2 places: 1- We instrument the loaders / actions on build, then we pass them down to the original implementations. 2- We use the `routes` inside them to create parameterised transactions. This update adds new internal wrappers around them to make sure that we don't miss out on the returned / resolved values in case `build` is a function, for both cases. This PR also adds a new E2E test application using the latest Remix version and Vite, and it runs the tests on `dev` mode. We also need a documentation update to reflect this, if it gets merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10724
Related: #9500
Adds dev-mode support to Remix setups with Vite and Express.
We currently accept Remix server
buildas an object to instrument. But Remix allowsbuildas a synchronous or asynchronous function that returns the build object. Currently, it seems that functions are only used in development servers, and not in production. So, while this update slightly reducesrequestHandlerperformance on dev servers, it does not on production builds.We need
buildin 2 places:1- We instrument the loaders / actions on build, then we pass them down to the original implementations.
2- We use the
routesinside them to create parameterised transactions.This update adds new internal wrappers around them to make sure that we don't miss out on the returned / resolved values in case
buildis a function, for both cases.This PR also adds a new E2E test application using the latest Remix version and Vite, and it runs the tests on
devmode.We also need a documentation update to reflect this, if it gets merged.