Skip to content

Improve support for Windows 10 webview URLs in the stack trace#1137

Merged
kamilogorek merged 1 commit intogetsentry:masterfrom
jazbek:patch-1
Jan 10, 2018
Merged

Improve support for Windows 10 webview URLs in the stack trace#1137
kamilogorek merged 1 commit intogetsentry:masterfrom
jazbek:patch-1

Conversation

@jazbek
Copy link
Contributor

@jazbek jazbek commented Nov 16, 2017

In Windows 10, webview urls will start with either ms-appx in local mode, or ms-appx-web in remote mode. In Cordova projects targeting Windows 10, the default is ms-appx-web. See the WindowsDefaultUriPrefix section on this page for more info: https://github.com/apache/cordova-windows/blob/master/cordova-windows10.md

Before submitting a pull request, please verify the following:

  • If you've added code that should be tested, please add tests.
  • If you've modified the API (e.g. added a new config or public method), update the docs and TypeScript declaration file.
  • Ensure your code lints and the test suite passes (npm test).

In Windows 10, webview urls will start with either ms-appx in local mode, or ms-appx-web in remote mode. In Cordova projects targeting Windows 10, the default is ms-appx-web. See the WindowsDefaultUriPrefix section on this page for more info: https://github.com/apache/cordova-windows/blob/master/cordova-windows10.md
@kamilogorek
Copy link
Contributor

kamilogorek commented Nov 17, 2017

Thanks for the update.

@kamilogorek kamilogorek merged commit ddd1200 into getsentry:master Jan 10, 2018
chargome added a commit that referenced this pull request Mar 17, 2026
Fixes Dependabot alert #1137.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chargome added a commit that referenced this pull request Mar 17, 2026
Fixes Dependabot alert #1137.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants