Merged
Conversation
jan-auer
requested changes
Nov 17, 2017
Member
There was a problem hiding this comment.
Awesome! What would be great is to suggest adding tags for the Electron version and OS platform to the events. I was thinking of:
Raven.config('___PUBLIC_DSN___', {
captureUnhandledRejections: true,
tags: {
electron: process.versions.electron,
chrome: process.versions.chrome,
process: process.versions.type,
platform: process.platform // if not sent by raven
}
}).install()Other than that, just one minor wording suggestion.
docs/integrations/electron.rst
Outdated
| Raven.captureException(event.reason); | ||
| }); | ||
|
|
||
| This configuration will also handle promises errors, which be handled in various way, however, by default Electron uses standard JS API. |
Member
There was a problem hiding this comment.
"will also handle Promise errors" or "unhandled Promise rejections"
kamilogorek
force-pushed
the
electron-docs
branch
from
375c141 to
3f506a0
Compare
jan-auer
approved these changes
Nov 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's something...