Skip to content

docs: Add unhandledRejection example for node#1146

Closed
paulirish wants to merge 1 commit intogetsentry:masterfrom
paulirish:patch-1
Closed

docs: Add unhandledRejection example for node#1146
paulirish wants to merge 1 commit intogetsentry:masterfrom
paulirish:patch-1

Conversation

@paulirish
Copy link

No description provided.

@kamilogorek
Copy link
Contributor

kamilogorek commented Nov 23, 2017

Do you use raven-js in any of your Node apps? We have raven-node for that scenario, and it already takes care of unhandled rejections and describes them in the documentation.

https://github.com/getsentry/raven-node/blob/master/lib/client.js#L117-L124
https://docs.sentry.io/clients/node/usage/#promises

@paulirish
Copy link
Author

paulirish commented Nov 27, 2017

lol ok. :)

Then what this points at is I've been browsing the "JavaScript" documentation for raven/sentry for a while now thinking it was indicative of how things work in Node. :) I now see "Node" is the key word.

What would have helped me is this major renaming across your docs:

  • Node -> Node.js JavaScript
  • JavaScript -> Browser JavaScript

Though, understandably, this is a big change.

@paulirish paulirish closed this Nov 27, 2017
@paulirish paulirish deleted the patch-1 branch November 27, 2017 20:41
@kamilogorek
Copy link
Contributor

We're working on v4, and it will definitely be easier to understand naming convention and what SDK to use where :)

chargome added a commit that referenced this pull request Mar 17, 2026
Fixes Dependabot alert #1146.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chargome added a commit that referenced this pull request Mar 18, 2026
Fixes Dependabot alert #1146.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants