Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 10, 2024

This PR deprecates the Hub interface as a continuation of #11528 where we deprecated the Hub class.

The difference here is that the interface will stay deprecated throughout v8 so that we can shim the infamous getCurrentHub API. Most other usages of the interface should already be removed in v8/develop 🤞

ref #11482

@Lms24 Lms24 self-assigned this Apr 10, 2024
@Lms24 Lms24 requested review from AbhiPrasad and mydea April 10, 2024 11:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.56 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.55 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.57 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.18 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.49 KB (+0.24% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.37 KB (+0.24% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.55 KB (+0.11% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.56 KB (+0.11% 🔺)
@sentry/browser - Webpack (gzipped) 22.78 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.67 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.04 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.82 KB (+0.16% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.2 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.48 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.29 KB (+0.16% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.55 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.06 KB (+0.18% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.03 KB (+0.1% 🔺)
@sentry/react - Webpack (gzipped) 22.81 KB (+0.18% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.87 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 54.01 KB (+0.12% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (0%)

@Lms24 Lms24 force-pushed the lms/feat-types-v7-deprecate-hub branch 2 times, most recently from ac16c58 to 376d33f Compare April 10, 2024 11:49
Base automatically changed from lms/feat-core-v7-deprecate-hub-class to v7 April 10, 2024 12:40
@Lms24 Lms24 force-pushed the lms/feat-types-v7-deprecate-hub branch from 5637eac to 5396579 Compare April 10, 2024 12:41
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 10, 2024
@AbhiPrasad
Copy link
Member

merging this in for #11540

@AbhiPrasad AbhiPrasad merged commit 5c35031 into v7 Apr 10, 2024
@AbhiPrasad AbhiPrasad deleted the lms/feat-types-v7-deprecate-hub branch April 10, 2024 16:09
@Lms24
Copy link
Member Author

Lms24 commented Apr 11, 2024

thanks @AbhiPrasad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants