Skip to content

Use window.location instead of document.location when possible #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mayfield wants to merge 1 commit into from
Closed

Use window.location instead of document.location when possible #1159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/raven.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1629,10 +1629,12 @@ Raven.prototype = {
};
}

if (_window.location && _window.location.href) {
httpData.url = _window.location.href;
} else if (_document.location && _document.location.href) {
Copy link
Contributor

@kamilogorek kamilogorek Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need a check for this._hasDocument here before accessing location

httpData.url = _document.location.href;
}
if (this._hasDocument) {
if (_document.location && _document.location.href) {
httpData.url = _document.location.href;
}
if (_document.referrer) {
Copy link
Contributor

@kamilogorek kamilogorek Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be merged into one if (this._hasDocument && _document.referrer)

if (!httpData.headers) httpData.headers = {};
httpData.headers.Referer = _document.referrer;
Expand Down