Skip to content

Add allowDuplicates to RavenOptions typescript definition#1178

Closed
Amos47 wants to merge 1 commit intogetsentry:masterfrom
Amos47:master
Closed

Add allowDuplicates to RavenOptions typescript definition#1178
Amos47 wants to merge 1 commit intogetsentry:masterfrom
Amos47:master

Conversation

@Amos47
Copy link

@Amos47 Amos47 commented Dec 18, 2017

Before submitting a pull request, please verify the following:

  • If you've added code that should be tested, please add tests.
  • If you've modified the API (e.g. added a new config or public method), update the docs and TypeScript declaration file.
  • Ensure your code lints and the test suite passes (npm test).

Problem

We are missing the definition allowing for the allowDuplicates option in the configuration for typescript projects.

Solution

Add the property to the typescript definition.

@Amos47 Amos47 requested a review from kamilogorek as a code owner December 18, 2017 20:51
@Amos47
Copy link
Author

Amos47 commented Dec 18, 2017

I just realized this get's fixed by #1134.

I'd really appreciate that getting merged.

@Amos47 Amos47 closed this Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant