test(solidstart): Add client performance e2e tests #12895
Conversation
andreiborza
added
the
Package: solidstart
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
lgtm, but I would strongly recommend reducing potential leakage between tests. It's not immediately relevant because the tests are running in serial right now, but once there are many tests, pulling them apart to parallelize is a huge pita
|
|
||
| test('sends a pageload transaction', async ({ page }) => { | ||
| const transactionPromise = waitForTransaction('solidstart', async transactionEvent => { | ||
| return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'pageload'; |
There was a problem hiding this comment.
You probably want to assert for a particular transaction name, otherwise the tests are gonna start leaking once you add more page.goto()s
| // The sentry solidRouterBrowserTracingIntegration tries to update such | ||
| // transactions with the proper name once the `useLocation` hook triggers. | ||
| const navigationTxnPromise = waitForTransaction('solidstart', async transactionEvent => { | ||
| return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'navigation'; |
There was a problem hiding this comment.
The waitForTransaction here and the one in the test above may leak into eachother.
| contexts: { | ||
| trace: { | ||
| op: 'pageload', | ||
| origin: 'auto.pageload.browser', |
There was a problem hiding this comment.
Follow up task: We likely want to emit auto.pageload.solidstart.router here.
There was a problem hiding this comment.
Thanks, will update this in a follow up PR.
| contexts: { | ||
| trace: { | ||
| op: 'navigation', | ||
| origin: 'auto.navigation.solid.solidrouter', |
There was a problem hiding this comment.
Follow-up, this should probably be solidstart.solidrouter
No description provided.