Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 10, 2024

This PR bumps sorcery to version 1.0.0. The changelog links to this PR which implies that the main changes made were to move the package to output ESM code.

The SvelteKit build complained a bit about it but moving from a static to a dynamic import worked, so I'll take that.

Tested with our e2e test apps and errors still appear correctly source-mapped in Sentry.

closes #13657

@Lms24 Lms24 requested review from a team, chargome and mydea and removed request for a team September 10, 2024 18:04
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – but some tests did not pass

@Lms24 Lms24 enabled auto-merge (squash) September 13, 2024 08:53
@Lms24 Lms24 merged commit 8711bdd into develop Sep 13, 2024
@Lms24 Lms24 deleted the lms/deps-sveltekit-bump-sorcery branch September 13, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated Subdependency in SvelteKit package

3 participants