Skip to content

ref: Update http instrumentation name for logging #13716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 3 commits into from
Sep 18, 2024
Merged

ref: Update http instrumentation name for logging #13716

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
062de4d
ref: Update http instrumentation name for logging
mydea Sep 18, 2024
a7c1388
fix linting
mydea Sep 18, 2024
e256dc1
Update packages/node/src/integrations/http.ts
mydea Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/node/src/integrations/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { ClientRequest, IncomingMessage, RequestOptions, ServerResponse } from 'node:http';
import type { Span } from '@opentelemetry/api';
import { diag } from '@opentelemetry/api';
import { HttpInstrumentation } from '@opentelemetry/instrumentation-http';
import { addOpenTelemetryInstrumentation } from '@sentry/opentelemetry';

Expand All @@ -23,6 +24,8 @@ import { getRequestUrl } from '../utils/getRequestUrl';

const INTEGRATION_NAME = 'Http';

const INSTRUMENTATION_NAME = '@opentelemetry_sentry-patched/instrumentation-http';

interface HttpOptions {
/**
* Whether breadcrumbs should be recorded for requests.
Expand Down Expand Up @@ -195,6 +198,17 @@ export const instrumentHttp = Object.assign(
},
});

// We want to update the logger namespace so we can better identify what is happening here
try {
_httpInstrumentation['_diag'] = diag.createComponentLogger({
namespace: INSTRUMENTATION_NAME,
});

// @ts-expect-error This is marked as read-only, but we overwrite it anyhow
_httpInstrumentation.instrumentationName = INSTRUMENTATION_NAME;
} catch {
// ignore errors here...
}
addOpenTelemetryInstrumentation(_httpInstrumentation);
},
{
Expand Down