test(e2e/solidstart): Skip hydration error to unblock CI #13824
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
approved these changes
Sep 28, 2024
Member
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
Yea I did the same in my PR. I'm not sure why the hydration error suddenly appears, but seems related to the dev server.
Could also do a page.reload() instead but both is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently blocked because a test in our solidStart e2e test app is failing. It seems like for some reason, when first accessing the
/error-boundaryroute, a hydration error is thrown that's caught by the set error boundary. I didn't get to the bottom of why this hydration error is being thrown but at least we can work around it by simply reloading the page before triggering the sample error. This PR does exactly that. We should follow up with a proper fix for this (cc @andreiborza when you get a chance)