ref(core): Constrain SdkProcessingMetadata to known keys#15577
Closed
AbhiPrasad wants to merge 2 commits intodevelopfrom
Closed
ref(core): Constrain SdkProcessingMetadata to known keys#15577AbhiPrasad wants to merge 2 commits intodevelopfrom
SdkProcessingMetadata to known keys#15577AbhiPrasad wants to merge 2 commits intodevelopfrom
Conversation
AbhiPrasad
requested review from
chargome and
mydea
and removed request for
a team
Contributor
size-limit report 📦
|
chargome
approved these changes
Mar 5, 2025
Member
chargome
left a comment
chargome
left a comment
There was a problem hiding this comment.
Looks good, but would that theoretically be a breaking change?
Contributor
Author
|
I guess this is a breaking change - but really nobody should be using these APIs other than us. Maybe we just leave a todo note and come back to this for v10? |
Contributor
Author
|
Will come back to this in v10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After working on #15570, I realized we should be more constrained about what we set on
SdkProcessingMetadata.This PR updates the
SdkProcessingMetadatatype to be more constrained, not allowing any key to be passed to it. This should make sure we are more critical of changes that could lead to increased memory pressure in the SDK (asSdkProcessingMetadatalives alongside the scope).