deps(dev): Add missing peer dependencies of dev dependencies by mydea · Pull Request #16751 · getsentry/sentry-javascript

mydea · 2025-06-27T07:26:37Z

This adds missing peer dependencies that yarn complains about. Nothing should change, fundamentally.

Extracted this out of #16744

github-actions · 2025-06-27T08:29:21Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	23.81 kB	-0.73%	-174 B 🔽
@sentry/browser - with treeshaking flags	22.53 kB	-5.15%	-1.22 kB 🔽
@sentry/browser (incl. Tracing)	39.42 kB	-0.51%	-200 B 🔽
@sentry/browser (incl. Tracing, Replay)	77.53 kB	-0.37%	-287 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	67.51 kB	-4.79%	-3.39 kB 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)	82.23 kB	-0.38%	-308 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)	94.34 kB	-0.4%	-371 B 🔽
@sentry/browser (incl. Feedback)	40.48 kB	-0.67%	-272 B 🔽
@sentry/browser (incl. sendFeedback)	28.49 kB	-0.74%	-210 B 🔽
@sentry/browser (incl. FeedbackAsync)	33.38 kB	-0.62%	-206 B 🔽
@sentry/react	25.58 kB	-0.69%	-176 B 🔽
@sentry/react (incl. Tracing)	41.38 kB	-0.55%	-225 B 🔽
@sentry/vue	28.26 kB	-0.4%	-111 B 🔽
@sentry/vue (incl. Tracing)	41.2 kB	-0.52%	-212 B 🔽
@sentry/svelte	23.83 kB	-0.75%	-178 B 🔽
CDN Bundle	25.36 kB	-0.55%	-139 B 🔽
CDN Bundle (incl. Tracing)	39.43 kB	-0.52%	-205 B 🔽
CDN Bundle (incl. Tracing, Replay)	75.36 kB	-0.34%	-251 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)	80.81 kB	-0.34%	-273 B 🔽
CDN Bundle - uncompressed	74.08 kB	-0.56%	-415 B 🔽
CDN Bundle (incl. Tracing) - uncompressed	117.11 kB	-0.56%	-652 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed	231.04 kB	-0.45%	-1.03 kB 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	243.85 kB	-0.43%	-1.05 kB 🔽
@sentry/nextjs (client)	43.02 kB	-0.55%	-237 B 🔽
@sentry/sveltekit (client)	39.85 kB	-0.58%	-229 B 🔽
@sentry/node	167.85 kB	+3.72%	+6.02 kB 🔺
@sentry/node - without tracing	100.59 kB	+1.83%	+1.8 kB 🔺
@sentry/aws-serverless	128.69 kB	+3.29%	+4.09 kB 🔺

View base workflow run

codecov · 2025-06-27T09:15:42Z

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:

Error deserializing json

Caused by: expected value at line 1 column 1

For more help, visit our troubleshooting guide.

mydea · 2025-06-27T10:53:15Z

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-resource-spans/test.ts


  const expectedScripts = [
    '/init.bundle.js',
-    '/subject.bundle.js',


this (subject) is not defined for this test, apparently some changed webpack version emits or does not emit the empty file anymore, but this should be OK.

mydea · 2025-06-27T10:53:35Z

dev-packages/node-integration-tests/package.json

-    "@nestjs/common": "11.0.16",
-    "@nestjs/core": "10.4.6",
-    "@nestjs/platform-express": "10.4.6",
+    "@nestjs/common": "11.1.3",


bumping & aligning to latest as that fixes some transitive dependency security issue.

mydea · 2025-06-27T10:53:53Z

packages/ember/package.json

    "ember-template-lint": "~4.16.1",
    "eslint-plugin-ember": "11.9.0",
-    "eslint-plugin-n": "16.0.1",
+    "eslint-plugin-n": "15.0.0",


downgrading because this actually requires eslint 8

mydea · 2025-06-27T10:54:09Z

packages/nuxt/src/runtime/utils.ts

 import { captureException, getClient, getTraceMetaTags, logger } from '@sentry/core';
 import type { VueOptions } from '@sentry/vue/src/types';
-import type { CapturedErrorContext } from 'nitropack';
+import type { CapturedErrorContext } from 'nitropack/types';


this apparently changed in a newer nitropack version 😭

should we extract this change out? Might be easier debug/rollback if we need to.

mydea · 2025-06-27T10:54:27Z

packages/solidstart/src/config/types.ts

 };

-export type SolidStartInlineConfig = Parameters<typeof defineConfig>[0];
+export type SolidStartInlineConfig = NonNullable<Parameters<typeof defineConfig>[0]>;


type is now possible undefined, which leads to problems.

AbhiPrasad

It might be nice to split out the nuxt and solidstart changes given they change application code, git blame/rollback will be easier.

AbhiPrasad · 2025-07-08T13:25:38Z

packages/nuxt/src/runtime/utils.ts

 import { captureException, getClient, getTraceMetaTags, logger } from '@sentry/core';
 import type { VueOptions } from '@sentry/vue/src/types';
-import type { CapturedErrorContext } from 'nitropack';
+import type { CapturedErrorContext } from 'nitropack/types';


should we extract this change out? Might be easier debug/rollback if we need to.

This just bumps the underlying transitive dependency on nitropack, which apparently changes some type imports. Extracted out of #16751

Lms24

Ah these are peer dependencies specified by other dependencies. Took me a minute to grasp. But makes sense 👍

This adds explicit peer dependecies in the solidstart package. Those are dev dependencies only. Importantly, that seems to bump some things that result in slightly different types we need to adjust to. Extracted out of #16751

This adds missing peer dependencies that yarn complains about. Nothing should change, fundamentally. some more refs

mydea · 2025-07-10T07:26:53Z

Extracted more user-facing changes out, now this should be more straightforward than before!

cursor

Bug: Sucrase Resolution Change Affects Transitive Dependencies

The sucrase resolution pattern in package.json was changed from **/sucrase to sucrase. This narrows the scope from all sucrase dependencies (including transitive) to only direct ones. Consequently, transitive dependencies requiring the getsentry/sucrase#es2020-polyfills custom fork will no longer receive it, potentially causing breakage if they rely on its ES2020 polyfills.

package.json#L151-L152

sentry-javascript/package.json

Lines 151 to 152 in a84aae3

    
           "cliui/wrap-ansi": "7.0.0", 
        
           "sucrase": "getsentry/sucrase#es2020-polyfills"

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

…ncy (#19824) It seems like we added `file-type` as a dependency in #16751 with the reason that yarn was complaining about a missing peer dependency. However, `file-type` is not a peer dependency but a dependency of `@nestjs/common`. So it should be installed anyway. Given CI passes, I'd rather remove it for now.

mydea self-assigned this Jun 27, 2025

mydea force-pushed the fn/add-peer-dependencies branch from 485df2e to d477e77 Compare June 27, 2025 08:16

mydea force-pushed the fn/add-peer-dependencies branch 2 times, most recently from c752ad0 to 25687c2 Compare June 27, 2025 09:02

mydea force-pushed the fn/add-peer-dependencies branch from f66c60e to 8e4e86b Compare June 27, 2025 10:42

mydea commented Jun 27, 2025

View reviewed changes

mydea force-pushed the fn/add-peer-dependencies branch from 8e4e86b to 4ee837d Compare July 8, 2025 07:55

mydea marked this pull request as ready for review July 8, 2025 08:30

mydea requested a review from a team as a code owner July 8, 2025 08:30

mydea requested review from AbhiPrasad, Lms24 and s1gr1d July 8, 2025 08:31

chargome approved these changes Jul 8, 2025

View reviewed changes

mydea force-pushed the fn/add-peer-dependencies branch from 2785d43 to 1e7a6d4 Compare July 8, 2025 11:33

AbhiPrasad reviewed Jul 8, 2025

View reviewed changes

mydea force-pushed the fn/add-peer-dependencies branch 2 times, most recently from 14cd14c to 519054d Compare July 9, 2025 11:29

mydea added a commit that referenced this pull request Jul 9, 2025

deps(nuxt): Add explicit peer dependencies & bump nitropack

51a5aee

This just bumps the underlying transitive dependency on nitropack, which apparently changes some type imports. Extracted out of #16751

This was referenced Jul 9, 2025

deps(nuxt): Add explicit peer dependencies & bump nitropack #16858

Merged

deps(solidstart): Add explicit peer deps as devDependencies #16860

Merged

mydea added a commit that referenced this pull request Jul 9, 2025

deps(nuxt): Add explicit peer dependencies & bump nitropack (#16858)

60063e8

This just bumps the underlying transitive dependency on nitropack, which apparently changes some type imports. Extracted out of #16751

Lms24 approved these changes Jul 9, 2025

View reviewed changes

deps: Add missing peer dependencies

74c5fcc

This adds missing peer dependencies that yarn complains about. Nothing should change, fundamentally. some more refs

mydea force-pushed the fn/add-peer-dependencies branch from 519054d to 74c5fcc Compare July 10, 2025 07:25

mydea changed the title ~~deps: Add missing peer dependencies~~ deps(dev): Add missing peer dependencies Jul 10, 2025

revert

a84aae3

mydea changed the title ~~deps(dev): Add missing peer dependencies~~ deps(dev): Add missing peer dependencies of dependencies Jul 10, 2025

mydea changed the title ~~deps(dev): Add missing peer dependencies of dependencies~~ deps(dev): Add missing peer dependencies of dev dependencies Jul 10, 2025

cursor bot reviewed Jul 10, 2025

View reviewed changes

mydea merged commit 2a7a74b into develop Jul 10, 2025
169 checks passed

mydea deleted the fn/add-peer-dependencies branch July 10, 2025 07:49

s1gr1d mentioned this pull request Jul 17, 2025

Convert @sentry/ember addon to V2 addon format #15835

Open

Lms24 mentioned this pull request Mar 18, 2026

chore(node-integration-tests): Remove unnecessary file-type dependency #19824

Merged

	"cliui/wrap-ansi": "7.0.0",
	"sucrase": "getsentry/sucrase#es2020-polyfills"

Uh oh!

Conversation

mydea commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Jun 27, 2025

❌ Unsupported file format

Uh oh!

mydea Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

mydea Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

mydea Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

mydea Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

AbhiPrasad Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

mydea Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

AbhiPrasad left a comment

Choose a reason for hiding this comment

Uh oh!

AbhiPrasad Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

mydea commented Jul 10, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Sucrase Resolution Change Affects Transitive Dependencies

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mydea commented Jun 27, 2025 •

edited

Loading

github-actions bot commented Jun 27, 2025 •

edited

Loading