Don't throw in background promise in withMontior#16777
Closed
zachkirsch wants to merge 1 commit intogetsentry:developfrom
Closed
Don't throw in background promise in withMontior#16777zachkirsch wants to merge 1 commit intogetsentry:developfrom
zachkirsch wants to merge 1 commit intogetsentry:developfrom
Conversation
3 tasks
timfish
approved these changes
Jul 1, 2025
Collaborator
timfish
left a comment
timfish
left a comment
There was a problem hiding this comment.
Seems fine to me but it does look like it impacted some session tests!
Contributor
Author
|
@timfish Looking at the code I'm not seeing an obvious bug, and I'm having trouble running the tests locally. If someone is available to zoom pair-program with me for a few minutes, I'd love to get this over the line. Otherwise, feel free to take over this PR! |
Member
|
@zachkirsch I'll take a look, thanks for the contribution! |
Collaborator
|
Looks like it only failed for Node v18 so I've re-run that job to see if it's a test flake! |
Collaborator
|
Looks like it was just a test flake so all looking good! |
Member
|
This has been fixed in #16792 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).