feat(vercel-edge): Do not vendor in all OpenTelemetry dependencies#16841
Merged
feat(vercel-edge): Do not vendor in all OpenTelemetry dependencies#16841
Conversation
7a7a455 to
0c471f9
Compare
Lms24
approved these changes
Jul 9, 2025
chargome
approved these changes
Jul 9, 2025
0c471f9 to
f121a5d
Compare
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, most of the OTEL dependencies have been
devDependenciesof the vercel-edge package. This PR fixes this by properly defining the dependencies we have.NOTE: This was not per se incorrect, just not really necessary - we used to inline all of these dependencies into the vercel-edge SDK.
Only the
@opentelemetry/sdk-trace-basedependency remains a devDependency, which means it is bundled in. Without this, edge routes somehow fail on next 13 :/