Conversation
Contributor
size-limit report 📦
|
bfbe6a6 to
7b61e1b
Compare
s1gr1d
approved these changes
Jul 10, 2025
768d7ce to
ed3c762
Compare
7b61e1b to
3454549
Compare
Base automatically changed from
lms/feat-core-beforeStartNavigationSpan
to
develop
July 10, 2025 11:06
3454549 to
5cc3c90
Compare
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds on top of #16863
this PR fixes a bug in standalone web vital spans where, if they were sent because of a navigation, they would incorrectly be added to the
navigationspan's trace instead of the initialpageloadspan's trace. This surfaced while dogfooding these spans on sentry and inspecting them in the EAP traceview.To fix this, I added a lifecycle hook in #16863 that triggers right before we start preparing the navigation span and hence, right before we recycle the propagation context to the new traceId. This PR now makes use of the new hook for CLS and LCP spans and it also makes the integration tests stricter to check for the correct trace ids.