feat(nextjs): Use afterProductionCompile hook for webpack builds#17655
Merged
feat(nextjs): Use afterProductionCompile hook for webpack builds#17655
afterProductionCompile hook for webpack builds#17655Conversation
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Contributor
size-limit report 📦
|
afterProductionCompile hook for webpack buildsafterProductionCompile hook for webpack builds
mydea
reviewed
Sep 19, 2025
mydea
reviewed
Sep 19, 2025
mydea
reviewed
Sep 19, 2025
mydea
reviewed
Sep 19, 2025
mydea
reviewed
Sep 19, 2025
mydea
approved these changes
Sep 19, 2025
Member
mydea
left a comment
There was a problem hiding this comment.
left some nit comments, but overall looks great! 🚀
Lms24
approved these changes
Sep 19, 2025
Member
Lms24
left a comment
There was a problem hiding this comment.
LGTM! Thanks for creating the helper functions. This is much more readable now
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This was referenced Sep 23, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the experimental
useRunAfterProductionCompileHookflag to be used with webpack as well which can save build time as sourcemaps are only uploaded once.We do this by:
getBuildPluginOptionsand getting rid of the separatewebpackPluginOptionslogicFollow up tasks will be to:
serverlesspath as this does not even exist in Next13Warning: Enabling this might affect build integrity as bundled files are mutated after the build ends.