feat: update eslint to v8 by JPeer264 · Pull Request #18264 · getsentry/sentry-javascript

JPeer264 · 2025-11-20T13:19:12Z

This upgrades our internal eslint config to use v8. Theoretically this is considered a breaking change. Since this is an internal @sentry-internal/* package, we can release this in a non-breaking fashion

With v8 couple of changes came. Some of them are affecting us, which required file changes:

simple-import-sort/import got couple of fixes
"Unused eslint-disable directive": Unused "eslint-disable" comments are now detected and marked as error
import/export got a false positive, which affects most of our index barrel files (I didn't want to disable it entirely, so I added a global disable in each affected barrel file)
- tracked here: import/export false positive with star reexports import-js/eslint-plugin-import#703

Merge checks

Rebased before merge to get the latest changes updated with the new version

github-actions · 2025-11-20T13:35:31Z

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario	Requests/s	% of Baseline	Prev. Requests/s	Change %
GET Baseline	9,050	-	11,766	-23%
GET With Sentry	1,746	19%	2,078	-16%
GET With Sentry (error only)	6,113	68%	7,762	-21%
POST Baseline	1,216	-	1,203	+1%
POST With Sentry	590	49%	614	-4%
POST With Sentry (error only)	1,092	90%	1,064	+3%
MYSQL Baseline	3,345	-	4,068	-18%
MYSQL With Sentry	463	14%	577	-20%
MYSQL With Sentry (error only)	2,712	81%	3,350	-19%

View base workflow run

dev-packages/browser-integration-tests/utils/replayHelpers.ts

Lms24

Theoretically this is considered a breaking change. Since this is an internal @sentry-internal/* package, we can release this in a non-breaking fashion

Before we merge this, let's check in with Electron, Lynx and React-Native SDK maintainers. They all use a 10.x version of @sentry-internal/eslint-config-sdk so we should make sure this change doesn't cause problems for them:

https://github.com/search?type=code&q=%40sentry-internal%2Feslint-config-sdk+owner%3Agetsentry+

I agree btw that we shouldn't have to stick to semver for this internal package. Let's just make sure we break no-one unexpectedly 😅

JPeer264 · 2025-11-26T09:19:15Z

@Lms24 I just asked internally and it seems to be ok for the others

Lms24

Nice! Had some clarifying questions but nothing blocking. Thanks for taking care of this!

Lms24 · 2025-12-02T10:57:45Z

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/scenario-mutation.js

  );
 }

-// eslint-disable-next-line @typescript-eslint/no-floating-promises


why is this rule no longer applied? (no objections here since it's a test but we still want this rule in src files)

It is a typescript eslint rule and it was never working, since it was a .js file. We didn't configure that plugin for JavaScript files

Lms24 · 2025-12-02T11:01:06Z

packages/angular/src/index.ts

@@ -1,3 +1,4 @@
+/* eslint-disable import/export */


l: can we add a small explanation why we disable this here and in the other files? I guess once the false positive gets fixed, we'd get an "unused directive" lint error, so whoever runs into this will have some context.

Good idea. I'll add a comment everywhere directly

Lms24 · 2025-12-02T11:05:49Z

packages/google-cloud-serverless/src/index.ts

  winterCGHeadersToDict,
  // eslint-disable-next-line deprecation/deprecation
  anrIntegration,
-  // eslint-disable-next-line deprecation/deprecation


Hmm I guess it doesn't flag the deprecation here anymore because only some signatures of this API are deprecated 🤔
I think that's probably fine, was just curious if you think there might be another reason.

sentry-javascript/packages/node-core/src/integrations/anr/index.ts

Lines 268 to 279 in a1cc675

export function disableAnrDetectionForCallback<T>(callback: () => T): T;

export function disableAnrDetectionForCallback<T>(callback: () => Promise<T>): Promise<T>;

/**

* Temporarily disables ANR detection for the duration of a callback function.

*

* This utility function allows you to disable ANR detection during operations that

* are expected to block the event loop, such as intensive computational tasks or

* synchronous I/O operations.

*

* @deprecated The ANR integration has been deprecated. Use `eventLoopBlockIntegration` from `@sentry/node-native` instead.

*/

export function disableAnrDetectionForCallback<T>(callback: () => T | Promise<T>): T | Promise<T> {

Very good point - I'll investigate into that one

Quite interesting - atm TypeScript does actually not inherit the jsdoc with the deprecated warning: microsoft/TypeScript#407

So it could be that the eslint plugin is now more like TypeScripts behavior and ignores that. I readded that: df47728 (#18264)

Lms24 · 2025-12-02T11:08:10Z

packages/node/src/integrations/tracing/fastify/fastify-otel/index.js

 /* eslint-disable jsdoc/require-jsdoc */
 /* eslint-disable max-lines */
 /* eslint-disable no-param-reassign */
+/* eslint-disable import/named */


l: why do we need this new disable directive?

same as here there seems to be a problem with opentelemetry. I added it ad the top, since this one is vendored in

packages/node/src/integrations/tracing/fastify/index.ts

packages/node/src/integrations/tracing/hapi/index.ts

Lms24 · 2025-12-02T11:15:08Z

packages/replay-worker/.eslintrc.js

      // these somehow fail with rollup.examples.config.mjs
      files: ['*.mjs'],
      rules: {
+        'import/named': 'off',


l: any reason for this?

For some reason there is an issue with rollup on this one

Lms24

thx for replying to my suggestions/questions!

JPeer264 force-pushed the jp/update-eslint branch from b779b41 to c8b1fd3 Compare November 20, 2025 13:26

JPeer264 force-pushed the jp/update-eslint branch from c8b1fd3 to b2f7836 Compare November 20, 2025 13:38

JPeer264 requested review from Lms24 and s1gr1d November 20, 2025 15:44

JPeer264 marked this pull request as ready for review November 20, 2025 15:45

JPeer264 requested a review from a team as a code owner November 20, 2025 15:45

JPeer264 force-pushed the jp/update-eslint branch 2 times, most recently from 5b9d895 to a6afd58 Compare November 21, 2025 16:12

s1gr1d reviewed Nov 24, 2025

View reviewed changes

dev-packages/browser-integration-tests/utils/replayHelpers.ts Show resolved Hide resolved

Lms24 reviewed Nov 24, 2025

View reviewed changes

JPeer264 force-pushed the jp/update-eslint branch 2 times, most recently from b2ce5c4 to de82cc5 Compare November 26, 2025 09:18

JPeer264 force-pushed the jp/update-eslint branch 2 times, most recently from bbc1816 to e6cd95c Compare November 26, 2025 12:22

JPeer264 requested review from Lms24 and s1gr1d November 26, 2025 16:46

Lms24 approved these changes Dec 2, 2025

View reviewed changes

JPeer264 added 5 commits December 2, 2025 13:45

feat: update eslint

98848a4

fix: readd deprecation warning

98df199

feat: add info why barrel files need eslint disable

0c8a787

fixup! fix: readd deprecation warning

316df6b

feat: update files after rebase

2cdbe7c

JPeer264 force-pushed the jp/update-eslint branch from 2819171 to 2cdbe7c Compare December 2, 2025 12:51

Lms24 approved these changes Dec 2, 2025

View reviewed changes

JPeer264 merged commit f271bbb into develop Dec 2, 2025
400 of 401 checks passed

JPeer264 deleted the jp/update-eslint branch December 2, 2025 16:03

antonis mentioned this pull request Dec 5, 2025

chore(deps): Bump eslint to v8 getsentry/sentry-react-native#5443

Merged

10 tasks

	export function disableAnrDetectionForCallback<T>(callback: () => T): T;
	export function disableAnrDetectionForCallback<T>(callback: () => Promise<T>): Promise<T>;
	/**
	* Temporarily disables ANR detection for the duration of a callback function.
	*
	* This utility function allows you to disable ANR detection during operations that
	* are expected to block the event loop, such as intensive computational tasks or
	* synchronous I/O operations.
	*
	* @deprecated The ANR integration has been deprecated. Use `eventLoopBlockIntegration` from `@sentry/node-native` instead.
	*/
	export function disableAnrDetectionForCallback<T>(callback: () => T \| Promise<T>): T \| Promise<T> {

Uh oh!

Conversation

JPeer264 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge checks

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

node-overhead report 🧳

Uh oh!

Uh oh!

Lms24 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JPeer264 commented Nov 26, 2025

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24 Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JPeer264 Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JPeer264 commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading

Lms24 left a comment •

edited

Loading

Lms24 Dec 2, 2025 •

edited

Loading

JPeer264 Dec 2, 2025 •

edited

Loading