fix(node): Include system message in anthropic-ai messages span#18332
Merged
fix(node): Include system message in anthropic-ai messages span#18332
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
de0a4f9 to
1b0d784
Compare
RulaKhaled
reviewed
Nov 27, 2025
Contributor
There was a problem hiding this comment.
I left some comments. Can you please add a description to the issue you're working on? it would be super helpful to see one before diving into the review 🙏
Also, node integration tests are failing, we need to update test expectations to include the new system prompts. Thanks!
isaacs
added a commit
that referenced
this pull request
Dec 1, 2025
1b0d784 to
65d6be5
Compare
2 tasks
RulaKhaled
approved these changes
Dec 2, 2025
Contributor
RulaKhaled
left a comment
There was a problem hiding this comment.
Thanks for making the changes
65d6be5 to
a606a21
Compare
a606a21 to
ad5a87a
Compare
Fixes JS-1223 Fixes GH-18331
ad5a87a to
0ceea43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18331
Closes #18365