feat(effect): Add client/server entrypoints without functionality#19649
Merged
JPeer264 merged 2 commits intojp/add-effect-sdkfrom Mar 5, 2026
Merged
feat(effect): Add client/server entrypoints without functionality#19649JPeer264 merged 2 commits intojp/add-effect-sdkfrom
JPeer264 merged 2 commits intojp/add-effect-sdkfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| @@ -1,5 +1,5 @@ | |||
| import { describe, expect, it } from 'vitest'; | |||
| import * as index from '../src'; | |||
| import * as index from '../src/index.client'; | |||
There was a problem hiding this comment.
Missing integration or E2E tests for feature
Low Severity
This is a feat PR introducing new client/server entrypoints, but it only includes a single basic unit test checking that captureException is defined. Per review rules, feat PRs are expected to include at least one integration or E2E test. Even though the effectLayer currently returns an empty layer, a test verifying it can be constructed without error on both client and server paths would help prevent regressions as functionality is added.
Triggered by project rule: PR Review Guidelines for Cursor Bot
| "import": "./build/esm/index.server.js", | ||
| "require": "./build/cjs/index.server.js" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Missing default fallback conditions in exports map
Medium Severity
The "." export in package.json only defines browser and node conditions with no import/require/default fallback. The comparable @sentry/nuxt package includes top-level "import" and "require" fallbacks after "browser" and "node". Without these, environments that don't set browser or node conditions (edge runtimes, some test runners, certain bundler configurations) will fail to resolve @sentry/effect.
JPeer264
force-pushed
the
jp/add-effect-sdk-stack/2
branch
from
88de317 to
85c00da
Compare
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
JPeer264
force-pushed
the
jp/add-effect-sdk-stack/2
branch
from
5bf9bde to
90184af
Compare
JPeer264
added a commit
that referenced
this pull request
Mar 11, 2026
…9649) That adds now the functionality to use the `Sentry.effectLayer` properly. **But** it doesn't do anything, which means right now, to keep the PRs small, it returns an empty layer. Following can be used without any Sentry functionality: ```js const MainLive = HttpLive.pipe(Layer.provide(Sentry.effectLayer({ dsn: "", tracesSampleRate: 1.0, debug: true, }))) MainLive.pipe(Layer.launch, NodeRuntime.runMain) ```
JPeer264
added a commit
that referenced
this pull request
Mar 11, 2026
…9649) That adds now the functionality to use the `Sentry.effectLayer` properly. **But** it doesn't do anything, which means right now, to keep the PRs small, it returns an empty layer. Following can be used without any Sentry functionality: ```js const MainLive = HttpLive.pipe(Layer.provide(Sentry.effectLayer({ dsn: "", tracesSampleRate: 1.0, debug: true, }))) MainLive.pipe(Layer.launch, NodeRuntime.runMain) ```
JPeer264
added a commit
that referenced
this pull request
Mar 13, 2026
…9649) That adds now the functionality to use the `Sentry.effectLayer` properly. **But** it doesn't do anything, which means right now, to keep the PRs small, it returns an empty layer. Following can be used without any Sentry functionality: ```js const MainLive = HttpLive.pipe(Layer.provide(Sentry.effectLayer({ dsn: "", tracesSampleRate: 1.0, debug: true, }))) MainLive.pipe(Layer.launch, NodeRuntime.runMain) ```
JPeer264
added a commit
that referenced
this pull request
Mar 17, 2026
…9649) That adds now the functionality to use the `Sentry.effectLayer` properly. **But** it doesn't do anything, which means right now, to keep the PRs small, it returns an empty layer. Following can be used without any Sentry functionality: ```js const MainLive = HttpLive.pipe(Layer.provide(Sentry.effectLayer({ dsn: "", tracesSampleRate: 1.0, debug: true, }))) MainLive.pipe(Layer.launch, NodeRuntime.runMain) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That adds now the functionality to use the
Sentry.effectLayerproperly. But it doesn't do anything, which means right now, to keep the PRs small, it returns an empty layer.Following can be used without any Sentry functionality: