Skip to content

feat(node-core,node): Add tracePropagation option to http and fetch integrations #19712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreiborza merged 1 commit into from
Mar 9, 2026
+472 −7
Merged

feat(node-core,node): Add tracePropagation option to http and fetch integrations #19712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...-core-integration-tests/suites/tracing/requests/fetch-no-trace-propagation/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/node-core';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { setupOtel } from '../../../../utils/setupOtel.js';

const client = Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
integrations: [Sentry.nativeNodeFetchIntegration({ tracePropagation: false })],
transport: loggingTransport,
});

setupOtel(client);
12 changes: 12 additions & 0 deletions ...de-core-integration-tests/suites/tracing/requests/fetch-no-trace-propagation/scenario.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/node-core';

async function run() {
Sentry.addBreadcrumb({ message: 'manual breadcrumb' });

await fetch(`${process.env.SERVER_URL}/api/v0`).then(res => res.text());
await fetch(`${process.env.SERVER_URL}/api/v1`).then(res => res.text());

Sentry.captureException(new Error('foo'));
}

run();
66 changes: 66 additions & 0 deletions ...es/node-core-integration-tests/suites/tracing/requests/fetch-no-trace-propagation/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';

describe('outgoing fetch with tracePropagation disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
test('does not inject trace headers but still creates breadcrumbs', async () => {
expect.assertions(5);

const [SERVER_URL, closeTestServer] = await createTestServer()
.get('/api/v0', headers => {
expect(headers['sentry-trace']).toBeUndefined();
expect(headers['baggage']).toBeUndefined();
})
.get('/api/v1', headers => {
expect(headers['sentry-trace']).toBeUndefined();
expect(headers['baggage']).toBeUndefined();
})
.start();

await createRunner()
.withEnv({ SERVER_URL })
.expect({
event: {
breadcrumbs: [
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
},
{
category: 'http',
data: {
'http.method': 'GET',
url: `${SERVER_URL}/api/v0`,
status_code: 200,
},
timestamp: expect.any(Number),
type: 'http',
},
{
category: 'http',
data: {
'http.method': 'GET',
url: `${SERVER_URL}/api/v1`,
status_code: 200,
},
timestamp: expect.any(Number),
type: 'http',
},
],
exception: {
values: [
{
type: 'Error',
value: 'foo',
},
],
},
},
})
.start()
.completed();
closeTestServer();
});
});
});
12 changes: 12 additions & 0 deletions ...e-core-integration-tests/suites/tracing/requests/http-no-trace-propagation/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/node-core';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { setupOtel } from '../../../../utils/setupOtel.js';

const client = Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
integrations: [Sentry.httpIntegration({ tracePropagation: false, spans: false })],
transport: loggingTransport,
});

setupOtel(client);
28 changes: 28 additions & 0 deletions ...ode-core-integration-tests/suites/tracing/requests/http-no-trace-propagation/scenario.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node-core';
import * as http from 'http';

async function run() {
Sentry.addBreadcrumb({ message: 'manual breadcrumb' });

await makeHttpRequest(`${process.env.SERVER_URL}/api/v0`);
await makeHttpRequest(`${process.env.SERVER_URL}/api/v1`);

Sentry.captureException(new Error('foo'));
}

run();

function makeHttpRequest(url) {
return new Promise(resolve => {
http
.request(url, httpRes => {
httpRes.on('data', () => {
// we don't care about data
});
httpRes.on('end', () => {
resolve();
});
})
.end();
});
}
66 changes: 66 additions & 0 deletions ...ges/node-core-integration-tests/suites/tracing/requests/http-no-trace-propagation/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';

describe('outgoing http with tracePropagation disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
test('does not inject trace headers but still creates breadcrumbs', async () => {
expect.assertions(5);

const [SERVER_URL, closeTestServer] = await createTestServer()
.get('/api/v0', headers => {
expect(headers['sentry-trace']).toBeUndefined();
expect(headers['baggage']).toBeUndefined();
})
.get('/api/v1', headers => {
expect(headers['sentry-trace']).toBeUndefined();
expect(headers['baggage']).toBeUndefined();
})
.start();

await createRunner()
.withEnv({ SERVER_URL })
.expect({
event: {
breadcrumbs: [
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
},
{
category: 'http',
data: {
'http.method': 'GET',
url: `${SERVER_URL}/api/v0`,
status_code: 200,
},
timestamp: expect.any(Number),
type: 'http',
},
{
category: 'http',
data: {
'http.method': 'GET',
url: `${SERVER_URL}/api/v1`,
status_code: 200,
},
timestamp: expect.any(Number),
type: 'http',
},
],
exception: {
values: [
{
type: 'Error',
value: 'foo',
},
],
},
},
})
.start()
.completed();
closeTestServer();
});
});
});
9 changes: 9 additions & 0 deletions .../node-integration-tests/suites/tracing/requests/fetch-no-trace-propagation/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
integrations: [Sentry.nativeNodeFetchIntegration({ tracePropagation: false })],
transport: loggingTransport,
});
12 changes: 12 additions & 0 deletions ...es/node-integration-tests/suites/tracing/requests/fetch-no-trace-propagation/scenario.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import * as Sentry from '@sentry/node';

async function run() {
Sentry.addBreadcrumb({ message: 'manual breadcrumb' });

await fetch(`${process.env.SERVER_URL}/api/v0`).then(res => res.text());
await fetch(`${process.env.SERVER_URL}/api/v1`).then(res => res.text());

Sentry.captureException(new Error('foo'));
}

run();
66 changes: 66 additions & 0 deletions ...ackages/node-integration-tests/suites/tracing/requests/fetch-no-trace-propagation/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';

describe('outgoing fetch with tracePropagation disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
test('does not inject trace headers but still creates breadcrumbs', async () => {
expect.assertions(5);

const [SERVER_URL, closeTestServer] = await createTestServer()
.get('/api/v0', headers => {
expect(headers['sentry-trace']).toBeUndefined();
expect(headers['baggage']).toBeUndefined();
})
.get('/api/v1', headers => {
expect(headers['sentry-trace']).toBeUndefined();
expect(headers['baggage']).toBeUndefined();
})
.start();

await createRunner()
.withEnv({ SERVER_URL })
.expect({
event: {
breadcrumbs: [
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
},
{
category: 'http',
data: {
'http.method': 'GET',
url: `${SERVER_URL}/api/v0`,
status_code: 200,
},
timestamp: expect.any(Number),
type: 'http',
},
{
category: 'http',
data: {
'http.method': 'GET',
url: `${SERVER_URL}/api/v1`,
status_code: 200,
},
timestamp: expect.any(Number),
type: 'http',
},
],
exception: {
values: [
{
type: 'Error',
value: 'foo',
},
],
},
},
})
.start()
.completed();
closeTestServer();
});
});
});
9 changes: 9 additions & 0 deletions ...s/node-integration-tests/suites/tracing/requests/http-no-trace-propagation/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
integrations: [Sentry.httpIntegration({ tracePropagation: false, spans: false })],
transport: loggingTransport,
});
28 changes: 28 additions & 0 deletions ...ges/node-integration-tests/suites/tracing/requests/http-no-trace-propagation/scenario.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node';
import * as http from 'http';

async function run() {
Sentry.addBreadcrumb({ message: 'manual breadcrumb' });

await makeHttpRequest(`${process.env.SERVER_URL}/api/v0`);
await makeHttpRequest(`${process.env.SERVER_URL}/api/v1`);

Sentry.captureException(new Error('foo'));
}

run();

function makeHttpRequest(url) {
return new Promise(resolve => {
http
.request(url, httpRes => {
httpRes.on('data', () => {
// we don't care about data
});
httpRes.on('end', () => {
resolve();
});
})
.end();
});
}
66 changes: 66 additions & 0 deletions ...packages/node-integration-tests/suites/tracing/requests/http-no-trace-propagation/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';

describe('outgoing http with tracePropagation disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
test('does not inject trace headers but still creates breadcrumbs', async () => {
expect.assertions(5);

const [SERVER_URL, closeTestServer] = await createTestServer()
.get('/api/v0', headers => {
expect(headers['sentry-trace']).toBeUndefined();
expect(headers['baggage']).toBeUndefined();
})
.get('/api/v1', headers => {
expect(headers['sentry-trace']).toBeUndefined();
expect(headers['baggage']).toBeUndefined();
})
.start();

await createRunner()
.withEnv({ SERVER_URL })
.expect({
event: {
breadcrumbs: [
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
},
{
category: 'http',
data: {
'http.method': 'GET',
url: `${SERVER_URL}/api/v0`,
status_code: 200,
},
timestamp: expect.any(Number),
type: 'http',
},
{
category: 'http',
data: {
'http.method': 'GET',
url: `${SERVER_URL}/api/v1`,
status_code: 200,
},
timestamp: expect.any(Number),
type: 'http',
},
],
exception: {
values: [
{
type: 'Error',
value: 'foo',
},
],
},
},
})
.start()
.completed();
closeTestServer();
});
});
});
Loading
Loading