Skip to content

feat(nestjs): Use more specific span origins for NestJS guards, pipes, interceptors, and exception filters #19751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 1 commit into from
Mar 11, 2026
Merged

feat(nestjs): Use more specific span origins for NestJS guards, pipes, interceptors, and exception filters #19751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions dev-packages/e2e-tests/test-applications/nestjs-11/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,15 +232,15 @@ test('API route transaction includes nest guard span and span started in guard i
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.guard',
},
description: 'ExampleGuard',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.guard',
},
]),
}),
Expand Down Expand Up @@ -296,15 +296,15 @@ test('API route transaction includes nest pipe span for valid request', async ({
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.pipe',
},
description: 'ParseIntPipe',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.pipe',
},
]),
}),
Expand Down Expand Up @@ -333,15 +333,15 @@ test('API route transaction includes nest pipe span for invalid request', async
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.pipe',
},
description: 'ParseIntPipe',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'internal_error',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.pipe',
},
]),
}),
Expand Down Expand Up @@ -372,30 +372,30 @@ test('API route transaction includes nest interceptor spans before route executi
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'ExampleInterceptor1',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
{
span_id: expect.stringMatching(/[a-f0-9]{16}/),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'ExampleInterceptor2',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
]),
}),
Expand Down Expand Up @@ -490,15 +490,15 @@ test('API route transaction includes exactly one nest interceptor span after rou
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'Interceptors - After Route',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
]),
}),
Expand Down Expand Up @@ -572,15 +572,15 @@ test('API route transaction includes nest async interceptor spans before route e
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'AsyncInterceptor',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
]),
}),
Expand Down Expand Up @@ -657,15 +657,15 @@ test('API route transaction includes exactly one nest async interceptor span aft
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'Interceptors - After Route',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
]),
}),
Expand Down
32 changes: 16 additions & 16 deletions dev-packages/e2e-tests/test-applications/nestjs-8/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,15 +236,15 @@ test('API route transaction includes nest guard span and span started in guard i
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.guard',
},
description: 'ExampleGuard',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.guard',
},
]),
}),
Expand Down Expand Up @@ -300,15 +300,15 @@ test('API route transaction includes nest pipe span for valid request', async ({
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.pipe',
},
description: 'ParseIntPipe',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.pipe',
},
]),
}),
Expand Down Expand Up @@ -337,15 +337,15 @@ test('API route transaction includes nest pipe span for invalid request', async
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.pipe',
},
description: 'ParseIntPipe',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'internal_error',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.pipe',
},
]),
}),
Expand Down Expand Up @@ -376,30 +376,30 @@ test('API route transaction includes nest interceptor spans before route executi
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'ExampleInterceptor1',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
{
span_id: expect.stringMatching(/[a-f0-9]{16}/),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'ExampleInterceptor2',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
]),
}),
Expand Down Expand Up @@ -494,15 +494,15 @@ test('API route transaction includes exactly one nest interceptor span after rou
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'Interceptors - After Route',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
]),
}),
Expand Down Expand Up @@ -576,15 +576,15 @@ test('API route transaction includes nest async interceptor spans before route e
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'AsyncInterceptor',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
]),
}),
Expand Down Expand Up @@ -661,15 +661,15 @@ test('API route transaction includes exactly one nest async interceptor span aft
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
data: {
'sentry.op': 'middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs',
'sentry.origin': 'auto.middleware.nestjs.interceptor',
},
description: 'Interceptors - After Route',
parent_span_id: expect.stringMatching(/[a-f0-9]{16}/),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
status: 'ok',
op: 'middleware.nestjs',
origin: 'auto.middleware.nestjs',
origin: 'auto.middleware.nestjs.interceptor',
},
]),
}),
Expand Down
Loading
Loading