Skip to content

tests(core): Fix flaky metric sequence number test #19754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 2 commits into from
Mar 11, 2026
Merged

tests(core): Fix flaky metric sequence number test #19754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5215171
fix(core): Fix flaky metric sequence number test
nicohrubec Mar 11, 2026
5f81bde
restore sp
nicohrubec Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/core/test/lib/metrics/internal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
} from '../../../src/metrics/internal';
import type { Metric } from '../../../src/types-hoist/metric';
import * as loggerModule from '../../../src/utils/debug-logger';
import * as timeModule from '../../../src/utils/time';
import { _INTERNAL_resetSequenceNumber } from '../../../src/utils/timestampSequence';
import { getDefaultTestClientOptions, TestClient } from '../../mocks/client';

Expand Down Expand Up @@ -1080,6 +1081,10 @@ describe('_INTERNAL_captureMetric', () => {

describe('sentry.timestamp.sequence', () => {
it('increments the sequence number across consecutive metrics', () => {
// Mock timestampInSeconds to return a fixed value so the sequence number
// does not reset due to millisecond boundary crossings between calls.
const timestampSpy = vi.spyOn(timeModule, 'timestampInSeconds').mockReturnValue(1234.567);

const options = getDefaultTestClientOptions({ dsn: PUBLIC_DSN });
const client = new TestClient(options);
const scope = new Scope();
Expand All @@ -1093,6 +1098,8 @@ describe('_INTERNAL_captureMetric', () => {
expect(buffer?.[0]?.attributes?.['sentry.timestamp.sequence']).toEqual({ value: 0, type: 'integer' });
expect(buffer?.[1]?.attributes?.['sentry.timestamp.sequence']).toEqual({ value: 1, type: 'integer' });
expect(buffer?.[2]?.attributes?.['sentry.timestamp.sequence']).toEqual({ value: 2, type: 'integer' });

timestampSpy.mockRestore();
});

it('resets the sequence number via _INTERNAL_resetSequenceNumber', () => {
Expand Down
Loading