Skip to content

feat(effect): Use options in buildEffectLayer without overriding#19794

Merged
JPeer264 merged 1 commit intojp/add-effect-sdkfrom
jp/add-effect-sdk-stack/8
Mar 13, 2026
Merged

feat(effect): Use options in buildEffectLayer without overriding#19794
JPeer264 merged 1 commit intojp/add-effect-sdkfrom
jp/add-effect-sdk-stack/8

Conversation

@JPeer264
Copy link
Member

To not mess with @sentry/core while adding the new SDK this, the options are directly moved into the Effect SDK. The main reason why this is now moved is that mutating the options could lead to other issues, and this is why I want to keep this in a separate and smaller PR.

@JPeer264 JPeer264 self-assigned this Mar 13, 2026
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 25.64 kB added added
@sentry/browser - with treeshaking flags 24.14 kB added added
@sentry/browser (incl. Tracing) 42.62 kB added added
@sentry/browser (incl. Tracing, Profiling) 47.28 kB added added
@sentry/browser (incl. Tracing, Replay) 81.42 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 71 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 86.12 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 98.37 kB added added
@sentry/browser (incl. Feedback) 42.45 kB added added
@sentry/browser (incl. sendFeedback) 30.31 kB added added
@sentry/browser (incl. FeedbackAsync) 35.36 kB added added
@sentry/browser (incl. Metrics) 26.92 kB added added
@sentry/browser (incl. Logs) 27.07 kB added added
@sentry/browser (incl. Metrics & Logs) 27.74 kB added added
@sentry/react 27.39 kB added added
@sentry/react (incl. Tracing) 44.95 kB added added
@sentry/vue 30.08 kB added added
@sentry/vue (incl. Tracing) 44.48 kB added added
@sentry/svelte 25.66 kB added added
CDN Bundle 28.27 kB added added
CDN Bundle (incl. Tracing) 43.5 kB added added
CDN Bundle (incl. Logs, Metrics) 29.13 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 44.34 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 68.2 kB added added
CDN Bundle (incl. Tracing, Replay) 80.32 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 81.22 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 85.86 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 86.76 kB added added
CDN Bundle - uncompressed 82.56 kB added added
CDN Bundle (incl. Tracing) - uncompressed 128.5 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 85.43 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 131.37 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 209.06 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 245.35 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 248.21 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 258.26 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 261.11 kB added added
@sentry/nextjs (client) 47.37 kB added added
@sentry/sveltekit (client) 43.07 kB added added
@sentry/node-core 56.34 kB added added
@sentry/node 173.19 kB added added
@sentry/node - without tracing 96.35 kB added added
@sentry/aws-serverless 113.34 kB added added

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,244 - - added
GET With Sentry 1,635 18% - added
GET With Sentry (error only) 6,080 66% - added
POST Baseline 1,176 - - added
POST With Sentry 570 48% - added
POST With Sentry (error only) 1,061 90% - added
MYSQL Baseline 3,228 - - added
MYSQL With Sentry 439 14% - added
MYSQL With Sentry (error only) 2,577 80% - added

@JPeer264 JPeer264 merged commit d5efd68 into jp/add-effect-sdk Mar 13, 2026
225 checks passed
@JPeer264 JPeer264 deleted the jp/add-effect-sdk-stack/8 branch March 13, 2026 09:08
JPeer264 added a commit that referenced this pull request Mar 17, 2026
)

To not mess with `@sentry/core` while adding the new SDK this, the
options are directly moved into the Effect SDK. The main reason why this
is now moved is that mutating the options could lead to other issues,
and this is why I want to keep this in a separate and smaller PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants