Change XHR instrumentation ordering#2643
Merged
kamilogorek merged 3 commits intomasterfrom Jun 8, 2020
Merged
Conversation
Contributor
HazAT
approved these changes
Jun 8, 2020
Contributor
|
Change XHR instrumentation ordering is a good idea. I think the better solution is I am going to refator in this way. Any other situation you can tell me when you try to solve this problem? @kamilogorek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where 3rd party libraries like Axios are attaching their own handler before ours, resulting in missing breadcrumb in the consecutive error event.
Ref: #1333 (comment)