ref: Use esm imports with localforage and add esModuleInterop#3403
Merged
kamilogorek merged 1 commit intomasterfrom Apr 16, 2021
Merged
ref: Use esm imports with localforage and add esModuleInterop#3403kamilogorek merged 1 commit intomasterfrom
kamilogorek merged 1 commit intomasterfrom
Conversation
kamilogorek
requested review from
a team,
iker-barriocanal and
lobsterkatie
and removed request for
a team
Contributor
size-limit report
|
Contributor
iker-barriocanal
left a comment
iker-barriocanal
left a comment
There was a problem hiding this comment.
Enabling
esModuleInteropwill also enableallowSyntheticDefaultImports.
from https://www.typescriptlang.org/tsconfig#esModuleInterop.
#3180 will this break?
Contributor
Author
|
We are not adding any |
iker-barriocanal
approved these changes
Apr 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3101
Fixes #3401
Closes #3294
esModuleInteropis recommended by TS Team - https://www.typescriptlang.org/tsconfig#esModuleInterop and we already use it in other packages.