ref(nextjs): Remove metadata builder class#4263
Merged
AbhiPrasad merged 3 commits intomasterfrom Dec 14, 2021
Merged
Conversation
Contributor
size-limit report
|
iker-barriocanal
suggested changes
Dec 13, 2021
Contributor
iker-barriocanal
left a comment
iker-barriocanal
left a comment
There was a problem hiding this comment.
There should be tests, why are we deleting them?
Refactor the class into functions to save on bundle size. Extracted from changes in #4196.
AbhiPrasad
force-pushed
the
abhi-metdata-builder-next
branch
from
68411dd to
cda910f
Compare
iker-barriocanal
approved these changes
Dec 14, 2021
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
* ref(nextjs): Remove metadata builder class Refactor the class into functions to save on bundle size. Extracted from changes in #4196. * add tests for nextjs metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the class into functions to save on bundle size. Extracted from
changes in #4196.