fix(react): Support root and wildcard routes in react router v6#5971
Merged
AbhiPrasad merged 1 commit intomasterfrom Oct 18, 2022
Merged
fix(react): Support root and wildcard routes in react router v6#5971AbhiPrasad merged 1 commit intomasterfrom
AbhiPrasad merged 1 commit intomasterfrom
Conversation
AbhiPrasad
requested review from
a team,
Lms24 and
lforst
and removed request for
a team
Lms24
approved these changes
Oct 18, 2022
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
LGTM, I think having the * in the route makes sense because it represents the users' actual routes and it's still parameterized and low-cardinality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5965
This PR does two things for the react router v6 instrumentation.
Makes sure that routes don't appear with double slashes, like with
//exampleor//my-route. This is done with a simple check forpathBuilder[pathBuilder.length - 1] === '/'.Make sure that wildcard imports will generate proper transaction names. For example with
/tests/123that loads a wildcard route, render/tests/:testId/*. Previously with wildcard routes we would only generate the wildcard portion, so it would render:testId/*.I'm still undecided if we should even keep the wildcards, but I think they are fine for now.