fix(browser): Handle case where fetch can be undefined#5973
Merged
AbhiPrasad merged 3 commits intomasterfrom Oct 25, 2022
Merged
fix(browser): Handle case where fetch can be undefined#5973AbhiPrasad merged 3 commits intomasterfrom
AbhiPrasad merged 3 commits intomasterfrom
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
requested review from
a team,
Lms24 and
lforst
and removed request for
a team
lforst
reviewed
Oct 18, 2022
| }, | ||
| })); | ||
| } catch (e) { | ||
| return rejectedSyncPromise(e); |
Contributor
There was a problem hiding this comment.
I am wondering what the long term outcome of this change is... If we go forward with this, we will probably just hide the fact that fetch is undefined behind a network error client report. Is that what we want?
Contributor
Author
There was a problem hiding this comment.
Yes this is tricky. I also realized that this change means we don't respect rate-limiting on the SDK at all...
Contributor
Author
|
Even if we hide this behind weird client outcomes, let's still ship this so folks get unblocked. |
lforst
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5792.
Some users reported cases where the
nativeFetchcall was returning undefined. I have no idea how this happens, but in order for us to not send unnecessary errors to Sentry, let's be a little defensive in the usage of fetch.