[react-native] Support for a custom URI normalization function#598
Closed
nevir wants to merge 1 commit intogetsentry:masterfrom
convoyinc-deprecated:rn-custom-normalizer
Closed
[react-native] Support for a custom URI normalization function#598nevir wants to merge 1 commit intogetsentry:masterfrom convoyinc-deprecated:rn-custom-normalizer
nevir wants to merge 1 commit intogetsentry:masterfrom
convoyinc-deprecated:rn-custom-normalizer
Conversation
…native asset paths You can now pass `normalizeUrl` as an argument when initializing the react native plugin. It is a function that returns the normalized path for use when retrieving release assets.
Contributor
Author
|
Ping on this |
Contributor
|
Cool. Would you mind separating this out into its own test, rather than override the original? I want to also verify that the original regex works. Also ... there is talk of just having a generic file processor for Raven.js (see: #600). I'm wondering if we should just implement that and be done with it (rather than make it a React Native specific thing). |
Contributor
Author
|
Closing in favor of #670 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now pass
normalizeUrlas an argument when initializing the react native plugin. It is a function that returns the normalized path for use when retrieving release assetsThis change is