ref(replay): Avoid using private hub._withClient#6494
Merged
Conversation
This was referenced Dec 12, 2022
Contributor
size-limit report 📦
|
Lms24
approved these changes
Dec 12, 2022
mydea
force-pushed
the
fn/replay-avoid-withClient
branch
2 times, most recently
from
61f2448 to
0f1d091
Compare
This is brittle, and can actually be refactored quite easily.
mydea
force-pushed
the
fn/replay-avoid-withClient
branch
from
0f1d091 to
c9e24bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is brittle, and can actually be refactored quite easily.
I also used the time to move the event/envelope creation out into dedicated methods, which we'll need to adapt later.
See: #6493