ref(replay): Add jsdoc to all replay modules#6654
Merged
Conversation
6 tasks
Contributor
size-limit report 📦
|
billyvg
approved these changes
Jan 4, 2023
mydea
force-pushed
the
fn/replay-jsdoc
branch
2 times, most recently
from
bdccf32 to
7e499a1
Compare
Lms24
approved these changes
Jan 5, 2023
Comment on lines
+28
to
29
| // Since we target only es6 here, we can leave this off | ||
| '@sentry-internal/sdk/no-async-await': 'off', |
mydea
force-pushed
the
fn/replay-jsdoc
branch
3 times, most recently
from
21b44ed to
72dfa77
Compare
This is one more step of #6323. Note that this also renames/moves a few things to make more sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one more step of #6323.
Note that this also renames/moves a few things to make more sense:
createPayload()tocreateRecordingData()getReplayEvent()toprepareReplayEvent()ReplayPerformanceEntrytype totypes.tscreateMemoryEntrytoaddMemoryEntry.ts, as that was actually the only place where this was used