ref(replay): Mark all methods & properties as public/private#6734
Merged
ref(replay): Mark all methods & properties as public/private#6734
Conversation
6 tasks
mydea
force-pushed
the
fn/replay-public-private
branch
from
d0b28e3 to
49c7d30
Compare
Contributor
size-limit report 📦
|
billyvg
approved these changes
Jan 11, 2023
mydea
force-pushed
the
fn/replay-public-private
branch
from
49c7d30 to
7e27a75
Compare
mydea
force-pushed
the
fn/replay-public-private
branch
from
7e27a75 to
cbbc97e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the
@typescript-eslint/explicit-member-accessibilityeslint rule & ensure we mark everything as private/public in replay.This also required renaming all the private stuff with
_XXX.ref: #6323