Skip to content

fix(remix): Use React.ComponentType instead of React.FC as withSentry's generic type. #9043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 2 commits into from
Sep 19, 2023
Merged

fix(remix): Use React.ComponentType instead of React.FC as withSentry's generic type. #9043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44349d4
Update performance.tsx
lifeiscontent Sep 18, 2023
16d59e8
Merge branch 'develop' into patch-1
AbhiPrasad Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/remix/src/client/performance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function remixRouterInstrumentation(useEffect: UseEffect, useLocation: Us
* @param OrigApp The Remix root to wrap
* @param options The options for ErrorBoundary wrapper.
*/
export function withSentry<P extends Record<string, unknown>, R extends React.FC<P>>(
export function withSentry<P extends Record<string, unknown>, R extends React.ComponentType<P>>(
OrigApp: R,
options: {
wrapWithErrorBoundary?: boolean;
Expand Down