Skip to content

ref(feedback): Add treeshaking for logger statements #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 1 commit into from
Nov 7, 2023
Merged

ref(feedback): Add treeshaking for logger statements #9475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/feedback/src/integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export class Feedback implements Integration {

this._widget = this._createWidget(this.options);
} catch (err) {
logger.error(err);
__DEBUG_BUILD__ && logger.error(err);
}
}

Expand All @@ -201,7 +201,7 @@ export class Feedback implements Integration {
typeof el === 'string' ? doc.querySelector(el) : typeof el.addEventListener === 'function' ? el : null;

if (!targetEl) {
logger.error('[Feedback] Unable to attach to target element');
__DEBUG_BUILD__ && logger.error('[Feedback] Unable to attach to target element');
return null;
}

Expand All @@ -210,7 +210,7 @@ export class Feedback implements Integration {
return widget;
});
} catch (err) {
logger.error(err);
__DEBUG_BUILD__ && logger.error(err);
return null;
}
}
Expand All @@ -222,7 +222,7 @@ export class Feedback implements Integration {
try {
return this._createWidget(mergeOptions(this.options, optionOverrides));
} catch (err) {
logger.error(err);
__DEBUG_BUILD__ && logger.error(err);
return null;
}
}
Expand All @@ -243,7 +243,7 @@ export class Feedback implements Integration {
return true;
}
} catch (err) {
logger.error(err);
__DEBUG_BUILD__ && logger.error(err);
}

return false;
Expand Down