Sending captured events should honor sending fail.

[stima]

Description

Sending captured events should honor sending fail.

When does the problem happen

• During build
• During run-time
• When capturing a hard crash

Environment

• OS: Unrelated
• Compiler: Unrelated
• CMake version and config: Unrelated

Steps To Reproduce

1. Generate crash under Sentry SDK. That should trigger unsent event inside sentry database folder
2. Turn off networking
3. Run Sentry SDK again.

Expected: The event is not send and event metadata is not removed, appropriate log statement raised.
Actual: Event is not send, event metadata is removed.

Log output

[supervacuus]

There is currently no transport transactionality of events. If an event ends up in the send queue and the transport cannot send for whatever reason, the event is lost. If your use case expects regular network unavailability and requires delivery guarantees, the transport implementation can be customized.

Send errors should be visible in the logs.

[stima]

Thanks I would consider to look to custom transport impelementation.

[supervacuus]

Btw since you use crashpad, implementing a custom transport will not help you with adding delivery guarantees for crashes since the crashpad_handler uses its own transport.