feat(crashpad): add option to delay shutdown until crash report upload completes (Linux)#1153
Merged
JoshuaMoelans merged 16 commits intomasterfrom Mar 25, 2025
Merged
Conversation
|
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 82.67% 82.63% -0.04%
==========================================
Files 53 53
Lines 7954 7959 +5
Branches 1246 1246
==========================================
+ Hits 6576 6577 +1
- Misses 1264 1268 +4
Partials 114 114 |
# Conflicts: # CHANGELOG.md # src/backends/sentry_backend_crashpad.cpp # src/sentry_options.c # src/sentry_options.h # tests/test_integration_crashpad.py
Member
Author
|
Do we already want to add the dockerfile & docker-compose files to the repo for posterity, or should we just leave them in the PR description as-is (until we add a proper Docker test into our CI testing setup) |
supervacuus
requested changes
Mar 25, 2025
Collaborator
I think it is enough to have it here. |
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
6 tasks
supervacuus
approved these changes
Mar 25, 2025
3 tasks
1 task
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some scenarios, waiting for the upload to complete makes more sense than trying to quickly kill the crashed process.
Crashpad PR getsentry/crashpad#121
We start by providing this for Linux, since this is the most common use-case for this kind of wait-before-shutdown behavior. If the need arises, we can reconsider adding it for other platforms as well.
add test(s)<- manually tested->
we can try getting the Docker testing setup into CI as well<- out of scope for this PRcrashpad-wait-for-uploadoption sentry-docs#13117Manual testing
Testing in CI is tricky, so we opted to test this on a local Docker setup instead. Below are the example
Dockerfileanddocker-compose.ymlthat we used to test this featuredockerfile
docker-compose.yml