Skip to content

feat: crashpad_wait_for_upload Windows support #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supervacuus merged 2 commits into from
Jun 5, 2025
Merged

feat: crashpad_wait_for_upload Windows support #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
497367e
feat: `crashpad_wait_for_upload` Windows support
supervacuus May 23, 2025
d6ae15a
update `crashpad` after merge to fork's `getsentry` branch
supervacuus Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

- Provide `before_send_transaction` callback. ([#1236](https://github.com/getsentry/sentry-native/pull/1236))
- Add support for capturing events with local scopes. ([#1248](https://github.com/getsentry/sentry-native/pull/1248))
- Add Windows support for the `crashpad_wait_for_upload` flag. ([#1255](https://github.com/getsentry/sentry-native/pull/1255), [crashpad#126](https://github.com/getsentry/crashpad/pull/126))

**Fixes**:

Expand Down
2 changes: 1 addition & 1 deletion external/crashpad
Open in desktop
Submodule crashpad updated 7 files
+8 −1 client/crashpad_client_win.cc
+5 −0 handler/crash_report_upload_thread.cc
+10 −0 handler/crash_report_upload_thread.h
+6 −6 handler/handler_main.cc
+9 −2 handler/win/crash_report_exception_handler.cc
+3 −1 handler/win/crash_report_exception_handler.h
+1 −1 third_party/mini_chromium/mini_chromium
3 changes: 2 additions & 1 deletion include/sentry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,7 +1374,8 @@ SENTRY_API void sentry_options_set_system_crash_reporter_enabled(
* Enables a wait for the crash report upload to be finished before shutting
* down. This is disabled by default.
*
* This setting only has an effect when using the `crashpad` backend on Linux.
* This setting only has an effect when using the `crashpad` backend on Linux
* and Windows.
*/
SENTRY_API void sentry_options_set_crashpad_wait_for_upload(
sentry_options_t *opts, int wait_for_upload);
Expand Down
Loading