fix: Unwind from local stack if ucontext fails#387
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 87.49% 87.53% +0.03%
==========================================
Files 49 49
Lines 4142 4147 +5
==========================================
+ Hits 3624 3630 +6
+ Misses 518 517 -1 |
Contributor
|
When we use direct unwind, do we need to skip 1 (or more) frame to hide sentry? |
Contributor
flub
approved these changes
Oct 2, 2020
Contributor
|
I'm not sure if we should hide frames. If this should be done at all perhaps just collapsing them by default in the UI is probably better (which I think might already happen)? |
Contributor
Author
|
We don’t flag frames as |
jan-auer
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Not quite sure if we should do this in the backend, or rather patch the unwinder itself…
fixes #384