fix(perf): Fix transaction setter on scope to use containing_transaction#1366
Merged
sl0thentr0py merged 3 commits intomasterfrom Mar 14, 2022
Merged
fix(perf): Fix transaction setter on scope to use containing_transaction#1366sl0thentr0py merged 3 commits intomasterfrom
sl0thentr0py merged 3 commits intomasterfrom
Conversation
…ion to match with getter
Member
|
I think it's fine to change this, but the entire business of getter and setter handling two different types is a headache which I'd love to see us fix. (It would take a new major, since it'd be a breaking change, but it's never led to anything but confusion, for us and users, so highly worth it, IMHO.) So while it's true that this would make what the issue creator is doing work, IMHO it's kind of an antipattern which we should remove from the docs even if we don't remove from the code. |
vladanpaunovic
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1155, not sure why we have this discrepancy between getter and setter behaviour in the first place