Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 8, 2024

Some CI checks aren't running on the sentry-sdk-2.0 branch (and PRs against it) yet (see e.g. #2596).

  • Run all relevant workflows on sentry-sdk-2.0
  • Fix lint step failures caused by a dependency update

General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana changed the base branch from master to sentry-sdk-2.0 January 8, 2024 14:55
@sentrivana sentrivana changed the base branch from sentry-sdk-2.0 to master January 8, 2024 14:55
@sentrivana sentrivana merged commit 6f41823 into master Jan 9, 2024
@sentrivana sentrivana deleted the ivana/run-more-ci-on-2.0-branch branch January 9, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants