-
Notifications
You must be signed in to change notification settings - Fork 571
chore: Drop even more deprecated stuff #4193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## potel-base #4193 +/- ##
==============================================
+ Coverage 83.47% 83.52% +0.05%
==============================================
Files 143 143
Lines 14678 14596 -82
Branches 2332 2310 -22
==============================================
- Hits 12252 12192 -60
+ Misses 1709 1686 -23
- Partials 717 718 +1
|
sentrivana
added a commit
that referenced
this pull request
Mar 26, 2025
The docstring for `Scope.user` says it's deprecated in favor of `Scope.set_user()`, but there is no user-facing warning. Add one so that we can [drop the property](#4193) in the next major. --------- Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
szokeasaurusrex
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop:
Scope.transactiondirectlyfailed_request_status_codesspanargument ofScope.trace_propagation_metaScope.userdirectly