tests(logs): avoid failures when running with integrations enabled#4388
Merged
antonpirker merged 1 commit intogetsentry:masterfrom May 20, 2025
Merged
Conversation
When (at least) one of integrations is enabled (because some dependencies are installed in the environment), `sentry.sdk.name` is changed from `sentry.python` to `sentry.python.[FIRST_ENABLED_INTEGRATION]` which makes `test_logs_attributes` fail. Prevent failure by relaxing the check. This change is beneficial not only for packaging (this patch was required for packaging for Fedora), but also for running tests with `pytest` directly. See also: getsentry#4316
rominf
force-pushed
the
rominf-test-logs-sentry.sdk.name
branch
from
d804713 to
7e10f72
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4388 +/- ##
==========================================
- Coverage 80.32% 80.32% -0.01%
==========================================
Files 142 142
Lines 15961 15961
Branches 2727 2727
==========================================
- Hits 12821 12820 -1
- Misses 2266 2267 +1
Partials 874 874 |
antonpirker
approved these changes
May 20, 2025
Contributor
antonpirker
left a comment
antonpirker
left a comment
There was a problem hiding this comment.
Looks good! Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When (at least) one of integrations is enabled (because some dependencies
are installed in the environment),
sentry.sdk.nameis changed fromsentry.pythontosentry.python.[FIRST_ENABLED_INTEGRATION]whichmakes
test_logs_attributesfail. Prevent failure by relaxing the check.This change is beneficial not only for packaging (this patch was required
for packaging for Fedora), but also for running tests with
pytestdirectly.
See also: #4316
Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval.